Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory not empty (os error 66 #22140

Open
1 of 4 tasks
berenddeboer opened this issue Mar 4, 2024 · 1 comment · May be fixed by #23279
Open
1 of 4 tasks

Directory not empty (os error 66 #22140

berenddeboer opened this issue Mar 4, 2024 · 1 comment · May be fixed by #23279
Assignees
@AgentEnder
Labels
scope: core core nx functionality type: bug

Comments

@berenddeboer
Copy link
Contributor

berenddeboer commented Mar 4, 2024 •
edited

Current Behavior

We are seeing this spurious error a lot. It's unclear what the cause it, but it seems to happen especially when there are a lot of affected files (i.e. change to root package.json). This has been going on basically ever since we use nx it feels (since the 16.x days).

This happens only during "git commit". We are using the pre-commit package to run "nx affected --target=build".

I'm just opening this issue to see if errors see this too. It seems to be a combination of pre-commit and nx, but what exactly is unclear, as the message comes from nx.

Typical output looks like:
image

Expected Behavior

Running nx by itself works fine.

GitHub Repo

No response

Steps to Reproduce

We don't really now.

Nx Report

NX   Report complete - copy this into the issue template

Node   : 18.19.0
OS     : darwin-arm64
pnpm   : 8.15.4

nx                 : 18.0.6
@nx/js             : 18.0.6
@nx/linter         : 18.0.6
@nx/eslint         : 18.0.6
@nx/workspace      : 18.0.6
@nx/cypress        : 18.0.6
@nx/devkit         : 18.0.6
@nx/esbuild        : 18.0.6
@nx/eslint-plugin  : 18.0.6
@nx/next           : 18.0.6
@nx/playwright     : 18.0.6
@nx/react          : 18.0.6
@nx/storybook      : 18.0.6
@nrwl/tao          : 18.0.6
@nx/vite           : 18.0.6
@nx/web            : 18.0.6
@nx/webpack        : 18.0.6
typescript         : 5.3.3
---------------------------------------
Community plugins:
@berenddeboer/nx-aws-cdk         : 2.2.2
@berenddeboer/nx-sst             : 0.13.5
@trumbitta/nx-plugin-unused-deps : 1.12.1
---------------------------------------
Local workspace plugins:
         @tc/nx-sst

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response
@FrozenPandaz FrozenPandaz added the scope: core core nx functionality label Mar 15, 2024
@Exelord
Copy link

Exelord commented May 9, 2024

We do confirm this issue. It is happening when running NX commands concurrently which are touching the cache. As they are not synchronized between each other they tend to clash on the current state.

We noticed to issues "os error 2" and "os error 66"

Error 2: can be easily fixed by checking if the path exist before deleting it
Error 66: Is about deleting a folder that has content inside. NX team would need to verify if this is intended if so either force remove it, or do nothing.

@Exelord Exelord linked a pull request May 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgentEnder AgentEnder

Labels
scope: core core nx functionality type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): Handle removing non-empty directories and non-existing paths in cache Exelord/nx
4 participants
@Exelord @berenddeboer @AgentEnder @FrozenPandaz