Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade openyurt to adapt k8s v1.24 #1699

Closed
wants to merge 17 commits into from
Closed

upgrade openyurt to adapt k8s v1.24 #1699

wants to merge 17 commits into from

Conversation

JameKeal
Copy link
Member

@JameKeal JameKeal commented Sep 8, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

adapt k8s v1.24 version for OpenYurt components

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

adapt k8s v1.24 version for OpenYurt components

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Sep 8, 2023
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Sep 8, 2023
@JameKeal JameKeal closed this Sep 8, 2023
@JameKeal JameKeal reopened this Sep 8, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JameKeal
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JameKeal
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JameKeal JameKeal closed this Sep 8, 2023
@JameKeal JameKeal reopened this Sep 9, 2023
@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023 •
edited

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b8c6e1) 51.75% compared to head (fa3e3e4) 51.74%.
Report is 102 commits behind head on master.

Files Patch % Lines
pkg/yurthub/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1699      +/-   ##
==========================================
- Coverage   51.75%   51.74%   -0.01%     
==========================================
  Files         163      163              
  Lines       19716    19689      -27     
==========================================
- Hits        10204    10189      -15     
+ Misses       8542     8534       -8     
+ Partials      970      966       -4
Flag Coverage Δ
unittests 51.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openyurt-bot openyurt-bot added size/XXL and removed size/XL size/XL: 500-999 labels Sep 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.2% 4.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@siredmar
Copy link
Contributor

@JameKeal is there still any work to do to get this PR merged?

@Congrool Congrool mentioned this pull request Dec 13, 2023
Closed
@stale Stale
Copy link

stale bot commented Jan 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 14, 2024
@Congrool Congrool linked an issue Jan 15, 2024 that may be closed by this pull request
[feature request]Support K8s v1.24~v1.28 #1806
Closed
@stale stale bot closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Congrool Congrool Awaiting requested review from Congrool

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

Assignees

@rambohe-ch rambohe-ch

Labels
kind/feature kind/feature size/XXL wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request]Support K8s v1.24~v1.28
4 participants
@JameKeal @openyurt-bot @siredmar @rambohe-ch