Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide configurable context for search hits #1767

Open
senthilkumarsh opened this issue Sep 9, 2017 · 5 comments · May be fixed by #3857
Open

provide configurable context for search hits #1767

senthilkumarsh opened this issue Sep 9, 2017 · 5 comments · May be fixed by #3857

Comments

@senthilkumarsh
Copy link

No description provided.

@vladak
Copy link
Member

vladak commented Sep 13, 2017

can you add more details please ?

@vladak
Copy link
Member

vladak commented Sep 18, 2017

Marking this as enhancement. However, this needs better specification to see what needs to be done. Or a pull request.

@senthilkumarsh
Copy link
Author

When we search for a content, we are showing only the matching line of content with line number. I need a customization option to include n lines before and after the actual line in the search result screen.

@vladak
Copy link
Member

vladak commented Oct 2, 2017

All right. This is something which probably needs to be done in Summarizer code.

@vladak vladak changed the title Include before and after content from file search provide configurable context for search hits Oct 2, 2017
@vladak vladak added the UI label Aug 30, 2018
@idodeclare
Copy link
Contributor

I have little design sense, but I'm thinking something like the following:

image

When you do a 0-context search, results would appear as they do now:

image

But if you specify to show some extra context, we make sure to clarify the non-contiguous sections. (We don't do that for 0-context search, but it's not a problem when every line has a highlight.)

image

I think up to 3 lines of surrounding context is a good maximum, because we still have to enforce the contextLimit:

image

But then the "more" view has the unlimited context:

image

This is all real BTW. Seeing if #2732 ever gets merged.

@idodeclare idodeclare linked a pull request Jan 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants