-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC 2024 Path Recorder: Phase 1 - Implement 'Trace Path' on Android #8214
Comments
The Recent Track feature already exists on iOS. For the upcoming Android Record Track feature, my plan is to first achieve feature parity with the existing iOS feature. It's fine if we improve both implementations later or simultaneously, but I prefer not to treat the current ongoing Android work as a greenfield, ground-up development. Let's restructure this ticket to propose incremental improvements to the existing iOS feature instead. The current ticket suggests too many changes at once. I'm afraid that it will get lost in discussions, jumping from one topic to another. It would be better to create more specialized tickets:
The color is already blue, isn't it? This looks non-actionable.
|
|
We should probably decide if we actually want to combine the two features into one. One option is to leave Recent Track on iOS as-is, not implement it on Android, and develop "Path Recorder" to serve both usages (it's still not clear that combining the two features can be done well). "Recent Track" is buried in Settings on iOS, and likely used by only a small number of people, so if they see "Path Recorder", maybe they are more likely to move to the new feature. |
Combining two features into one with a button is easy: use one button to start and stop recording when necessary. Automatically save the track. Make deleting it very easy (e.g. tap it on the map, and delete from the track's Place Page). A question is: can we improve the UX without explicit user action of starting/stopping recording? |
That sounds scary, even if I wouldn't need to be concerned about whatnot. And there are people easier scared than me. Also my Granny would like to keep battery consumption low without tangling with the options menu. IMO an easy to reach on/off switch would be appropriate (mandatory?) |
A switch on the map is very different to a switch in settings. |
I wouldn't know coding wise; From a user perspective, It might nail it. |
At this point the two options seem to be:
|
Let's avoid going deep into the weeds and just call it "Option 1: Track Recorder and Recent Track Recorder as separate features".
I have doubts that it is really an option, but let's track it as "Option 3. Remove Recent Track". There is also Option 2. Merging of both the features (Recent Track recorder and Track recorder). The initial version of this idea is already depicted in Figma (@oleg-rswll and @biodranik have access to).
Kavi has summarized the pros and cons of existing options in https://docs.google.com/document/d/1LVSluz5nqxViwRDimgHdWYT-f2LW6uYgMMRb0Vv4Zks/edit. |
I need to mention that #8183 implementing Recent Track on Android, "as in iOS," is already under review. If anyone strongly supports Option 3, "Remove Recent Track," you are welcome to share your arguments by Monday. Otherwise, we will eliminate Option 3 and narrow the selection to two options. |
I found a ticket dated Nov 2023: #6678 |
Arguments for removing recent track as a separate feature in settings:
|
Updated the requirements at the top to incorporate the discussions in this Issue and in Figma. The scope of work in this Issue is like an epic, so it will need to be broken down, one way is to use a task list and covert the tasks into Issues. |
Thanks for consolidating all requirements. I plan to get implemented it "like on iOS" first and continue with incremental improvements based on the new requirements after. Step by step. |
I had a conversation with @oleg-rswll on this topic last night. Roman's start position: Let's release an initial version to users as soon as possible, and then improve it over time. Agreement: Add a toggle to enable Recent Track in the main menu instead of in Settings. This button can be replaced with the proper Track Recorder in the future and users will not need to relearn. The recording interval will be fixed at a constant value (either 12 or 24 hours - TBD), without no option provided. Rough sketch: Please note that on Android, this feature has an ongoing notification in the notification bar, as required by the platform. Therefore, there is no strong need to duplicate the recording indication on the map screen: Action items:
|
@oleg-rswll, we probably still want two items below. They sound reasonable to me.
Let's implement them by using standard system dialogs.
|
It would be better to focus on reducing the battery usage and avoid annoying users about turning off something they anyway know (from the sticky notification). |
"Recent Path" name will be used everywhere, correct? |
@biodranik Displaying a message doesn't mean there should not be focus on reducing battery consumption. Unless the Recent Path feature can have nearly zero effect on battery, a message will be needed after some period of time. |
What about keeping the selector of hours in settings as it is and adding one more easy to turn on/off recent path button in main menu as you proposed. By this control will be more towards user side as well as it will be easier for them to turn it off and on. And from development side work will also be not much because setting feature is already there just one extra button will be needed. |
Can you please elaborate which problem this message solves on Android? There is already a sticky notification that will be annoyingly reminding users about active feature. There is no need to annoy users even more. Note that this sticky notification is not present on iOS. It is important to keep in mind important differences between platforms and not blindly copy patterns (which may not be the best ones anyway). |
Can we settle on displaying a disclaimer on the first usage of this feature ("When the feature is activated for the first time...") and not displaying any periodic message ("When the feature has been active for X hours...")? |
Sounds good to me. |
@oleg-rswll the new title is confusing. This is not a phase 1 of the entire GSoC 2024. We can say that it is a phase 1 of The Track Recorder for Android GSoC 2024 project. But honestly, it was more like a warm-up task ;) |
@rtsisyk issue name updated. |
Updated the design for this phase: |
The plan how to move forward: #8183 (comment) |
Updated designs with the latest: |
PTAL comments in Figma. |
See comments in Figma. |
Will this icon be later changed to a different recording icon? Or there will be two new menu items with two different icons for the recent track and recorder (I would prefer to avoid it)? |
@rtsisyk it probably makes more sense to have this feature as the second item in the Main Menu list, just below 'Add place to OpenStreetMap'. The 'Map Downloads' functionality is more like a setting that realistically should be automated so that user interaction is not required. 'Settings' is secondary as it's not a feature. 'Donate' has to do with the company, and not at all a feature. So good to have features higher, to be more easily accessible. |
@biodranik In Phase 2, the icon will be change to a record icon to reflect the ability to record. |
Download is an important button now (it was even on the main map screen, and may be a good idea to get it back there) for the following reasons:
Until the map downloading/updating process is not automated, this Download/Update button/dialog should be in the focus. |
The entire map management experience has a big opportunity for improvement, it should be a lot smoother and should required almost no continuous interaction, it should be an experience closer to online maps. For example the first run experience should set how this is managed, and then it should be mostly hands-off. Of course the functionality and UX needs to be worked through - #5668, #5679 and #7210 mention this, and the use cases you mention, the entire journey needs to be addressed. It may not be great to having functionality that should be mostly in the background running automatically, highlighted as the second feature. Seems like a lot of effort is happening in making a case just to have downloads as the second option instead of third option. |
IMHO "Recent Track" is much more clear (and common). I don't see a connection between a "Track" in the name and an ability to save it. While "Trace Path" is not clear to me. I guess as a new user I'd have to try enable it to understand what it does.. |
For sake of time, let's move forward with "Trace Path" and rename it to "Record Track" shortly after implementing "Save" feature.
Let's add it below "Downloads maps" and close this topic. We will never move forward if continue to discuss every bikeshed. |
@pastk @patepelo @foss-, "Trace Path" vs "Recent Track" was actively discussed in #6678 (and ten other threads). For sake of time, let's move forward with "Trace Path" and rename ii to "Record Track" as soon as we get the track saving into bookmarks implemented. This bikeshed is not really worth arguing. I can even expect that we would implement the saving feature at the same time as we finish #8183, so this "Trace Path" may not happen at all. |
We have enough confusing tickets here. Please review "#8215 Phase 2: Basic Track Recorder" section in Figma and add your comments to it. Editing: I am keeping this ticket open and unlocked, but please consider commenting UI design in Figma instead. |
Overview
Implement the Trace Path (aka "Recent Track") feature on Android to achieve feature parity with iOS. (This feature was previously available in MAPS.ME but was removed from the Android version due to new Google policies regarding background operations. Reference: #1807)
Problem Statement
Criteria
Main menu
Settings
Activation
Functionality
Main Screen
Notification
The text was updated successfully, but these errors were encountered: