New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] Change text "X objects" to "Y places, Z tracks" in Bookmarks and Tracks dialog #8217

Open

biodranik opened this issue May 19, 2024 · 0 comments · May be fixed by #8245

Labels

Bookmarks and Tracks Good first issue iOS

Member

biodranik commented May 19, 2024 •

edited

If a list contains both bookmarks and tracks, then "X objects" is printed instead of more precise and informative "Y places, Z tracks". This should be improved.

It is already implemented for Android, so the same approach/string placeholders can be reused.

Note that Android properly prints singular and plural forms, e.g. "1 place, 1 track" and "2 places, 1 track".

biodranik added Good first issue iOS Bookmarks and Tracks labels

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

3eae94f

- Refactor using a switch statement

Fixes: organicmaps#8217
Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier linked a pull request

that will close this issue

[ios] Change text "X objects" to "Y places, Z tracks" in Bookmarks and Tracks dialog #8245

Open

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

790f062

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

1d9a78b

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

3cd80e6

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

0cf8562

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

5f26735

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

ccc1a0c

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

4fc5120

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

e3d99e1

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Add a case for when bookmarks and tracks are greater than 0

b6ec65e

- Refactor using a switch statement

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks

9dbb601

- Remove “objects” from strings.txt;
- Remove “objects” from LocalizedStrings;

Fixes: organicmaps#8217
Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks

d56c272

- Remove “objects” from strings.txt;
- Remove “objects” from LocalizedStrings;

Fixes: organicmaps#8217
Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks in ui string

b6ab133

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Remove objects in locales

914ce76

- Remove “objects” from strings.txt;
- Remove “objects” from LocalizedStrings;

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks in ui string

2f2f23a

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Remove objects in locales

346bc38

- Remove “objects” from strings.txt;
- Remove “objects” from LocalizedStrings;

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Remove “objects” in ui string

ff2b1b2

- Remove “objects” in locales;
- Remove “objects” from strings.txt;
- Remove “objects” from LocalizedStrings;

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks in ui string

2c657eb

- Remove “objects” from strings.txt.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

ed60a67

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks in ui string

09565f3

- Remove “objects” from strings.txt.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

06d8af6

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks in ui string

5cd5333

- Remove “objects” from strings.txt.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

eda934b

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks in ui string

71027a4

- Remove “objects” from strings.txt.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] Replace objects via bookmarks and tracks in ui string

9a04e75

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

9da7872

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [ios] Replace objects via bookmarks and tracks in ui string

8ea2feb

- Remove “objects” from strings.txt.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] Replace objects via bookmarks and tracks in ui string

c02917f

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

54961fc

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

8063efb

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

e0976b8

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

biodranik pushed a commit that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

8c93d95

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: #8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

biodranik pushed a commit that referenced this issue


          [strings] Regenerated

9c4a214

Fixes: #8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

f33d218

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

bfb04f1

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

93eb368

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

3b1826a

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

3bc6040

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

8a28aad

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

dde9435

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

52ad0b2

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

cb6ff87

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

15dca90

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

08d9707

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

8d42649

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

46c934d

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

405efcb

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [android] [ios] Replace objects via bookmarks and tracks in ui string

48a2316

- Remove “objects” from strings.txt;
- Add condition flow for Android;
- Add condition flow for iOS.

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

itfarrier added a commit to itfarrier/organicmaps that referenced this issue


          [strings] Regenerated

e12ea4b

Fixes: organicmaps#8217

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment