OAuth access_token endpoint returns 200 for invalid requests #101455
Unanswered
colemickens
asked this question in
API and Webhooks
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Bug
Body
Hi,
Just lost a bit of time to this today.
GitHub's OAuth
access_tokens
endpoint returns 200 for invalid requests.This is quite annoying as SDKs tend to surface this in an unfortunate way - they think the request was valid, and then fail to deserialize the response.
It seems like a 4xx, maybe like 400, 401, 403 might be more appropriate than a 200 here.
Beta Was this translation helpful? Give feedback.
All reactions