Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key down sound not play if another key is already pressed. #127

Open
sloganking opened this issue Feb 8, 2024 · 2 comments
Open

Key down sound not play if another key is already pressed. #127

sloganking opened this issue Feb 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sloganking
Copy link
Contributor

Describe the bug

Pressing down two keys in a row only creates one key down sound. That is until the first key is released, at which point another key down sound will be played for the second key that was pressed down. But that sound is played out of sync with when that key was pressed.

To reproduce

PressDown KeyA, (hear keypress sound)
PressDown KeyB (Don't hear a keypress sound)

Expected behavior

A Keydown sound should be played each time a key is pressed down. Regardless of whether another key is already pressed down or not.

Software information

  • Operating system:
    image

  • Rust version: cargo 1.75.0 (1d8b05cdd 2023-11-20)

  • Project version: daktilo 0.5.0

@sloganking sloganking added the bug Something isn't working label Feb 8, 2024
@sloganking
Copy link
Contributor Author

Completing #46 might inadvertently fix this as well

@sloganking
Copy link
Contributor Author

sloganking commented Feb 8, 2024

I have implemented the code for this and can post it after I sleep. Thinking about it though. Do we want to be able to play two key down sounds in a row? Modern keyboards allow that but I am not sure if typewriters forced you to unpress one key before pressing another. Let me know.

Edit:

Reguardless, the current functionality of pressing down 5 keys and hearing one pressed down sound. And unpressing them all and hearing 5 unpressed sounds, is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants