Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Open new window in current PWD #23

Closed
jzbor opened this issue Apr 9, 2024 · 5 comments
Closed

Feature Request: Open new window in current PWD #23

jzbor opened this issue Apr 9, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@jzbor
Copy link
Contributor

jzbor commented Apr 9, 2024

Hi,
I am considering switching to kermit from my own vte implementation, but I really depend on one feature:
I use Ctrl+Return to spawn a new window with the working directory set to the current one. You can find the implementation here. The main functionality is provided by vte through vte_terminal_get_current_directory_uri().

Also is it possible to remap the default keys (i.e. use a different key for one of the default actions or remove a binding for one of the default actions)?

Thanks for the great work!

@orhun
Copy link
Owner

orhun commented Apr 9, 2024

Hello! kermit is not under active development however I'd love to have this feature in! Would you be possibly interested in contributing?

The key bindings are not fully configurable, see .config/kermit.conf.

@jzbor
Copy link
Contributor Author

jzbor commented Apr 10, 2024

Yes I would be open to contributing.

I was also thinking about implementing more configurable keybindings: Something like bindi for internal bindings and allowing for individual modifiers. Would you be open to such changes as well? Should I open a separate issue/draft PR?

@jzbor
Copy link
Contributor Author

jzbor commented Apr 10, 2024

I have created two pull requests regarding the two features. If you want to accept these contributions I will also make sure to add documentation.

As for the internal-keybindings thing: The way it is implemented it does not contain any defaults anymore and is therefore also a breaking change. This could be worked around if desired, but maybe this is the cleanest option.

@orhun orhun added the enhancement New feature or request label Apr 11, 2024
@orhun
Copy link
Owner

orhun commented Apr 11, 2024

I like the both PRs! (no backdoors though, what!??)

We can move forward with them, so please add docs! 🚀

I will try them out myself in the following days.

As for the internal-keybindings thing: The way it is implemented it does not contain any defaults anymore and is therefore also a breaking change.

Does it mean we need to include the defaults in the config?

jzbor added a commit to jzbor/kermit that referenced this issue Apr 11, 2024
jzbor added a commit to jzbor/kermit that referenced this issue Apr 11, 2024
@jzbor
Copy link
Contributor Author

jzbor commented Apr 11, 2024

I have now added docs and rebased #25 onto #24.

Does it mean we need to include the defaults in the config?

Yes. It would either have to be added in the code or in the suggested config file.

jzbor added a commit to jzbor/kermit that referenced this issue May 9, 2024
jzbor added a commit to jzbor/kermit that referenced this issue Jun 2, 2024
jzbor added a commit to jzbor/kermit that referenced this issue Jun 2, 2024
@orhun orhun closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants