Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update opened UI on lib.setMenuOptions() #279

Open
mahanmoulaei opened this issue Mar 23, 2023 · 1 comment
Open

[Enhancement] Update opened UI on lib.setMenuOptions() #279

mahanmoulaei opened this issue Mar 23, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mahanmoulaei
Copy link

mahanmoulaei commented Mar 23, 2023

Is your feature request related to a problem? Please describe.
It would be nice to reflect the menu changes with a NUI message for the open menu when lib.setMenuOptions() is called.

Without this feature, it takes more code to hide the menu, modify the default value of the scroll options(which needs re-registering of the menu or to call lib.setMenuOptions() on them), set the menu's startIndex, and finally open it again.

Describe the solution you'd like
Send a simple NUI message to the UI to reflect and update the changes in the menu once lib.setMenuOptions() is triggered and the menu id that is passed as the parameter matches with the menu id that is already open.

Additional context
I noticed this feature could assist with the development of a menu when I was working on a menu with scroll options that upon interacting, should change another option's attributes such as label, description, values, args, etc...

@mahanmoulaei mahanmoulaei added the enhancement New feature or request label Mar 23, 2023
@mahanmoulaei mahanmoulaei changed the title [Enhancement] [Enhancement] Update opened UI on lib.setMenuOptions() Mar 23, 2023
@jag3dagster
Copy link
Contributor

This feature has been requested in the past (#121) and I have even submitted a PR with the functionality (#98). Previously it was considered undesired as the menu was not intended to be super-reactive. If this philosophy has changed I can resubmit the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants