Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter/jsx-no-undef): check for globals when an identifier is undefined #3331

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented May 17, 2024

closes #3319

Copy link

graphite-app bot commented May 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented May 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label May 17, 2024
@Boshen Boshen force-pushed the 05-17-fix_linter_jsx-no-undef_check_for_globals_when_an_identifier_is_undefined branch from 5c62315 to 6a6257a Compare May 17, 2024 14:11
Copy link

graphite-app bot commented May 17, 2024

Merge activity

Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #3331 will not alter performance

Comparing 05-17-fix_linter_jsx-no-undef_check_for_globals_when_an_identifier_is_undefined (6c3d99a) with main (385965f)

Summary

✅ 27 untouched benchmarks

@Boshen Boshen force-pushed the 05-17-fix_linter_jsx-no-undef_check_for_globals_when_an_identifier_is_undefined branch from 6a6257a to 6c3d99a Compare May 17, 2024 14:20
@graphite-app graphite-app bot merged commit 6c3d99a into main May 17, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 05-17-fix_linter_jsx-no-undef_check_for_globals_when_an_identifier_is_undefined branch May 17, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react/jsx-no-undef consistency
1 participant