Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix: do not colour FormGroup sub label based on intent #6811

Merged
merged 3 commits into from
May 20, 2024
Merged

[core] fix: do not colour FormGroup sub label based on intent #6811

merged 3 commits into from
May 20, 2024

Conversation

berryde
Copy link
Contributor

@berryde berryde commented May 18, 2024 •
edited

Fixes #6808

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

No longer derive the sub label colour of FromGroup from the intent.

Screenshot

Before

image

image

After

image

image

@changelog-app
Copy link

changelog-app bot commented May 18, 2024 •
edited by berryde

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Do not colour FormGroup sub label based on intent

Check the box to generate changelog(s)

  • Generate changelog entry

@berryde berryde changed the title Update _form-group.scss Do not colour FormGroup sub label based on intent May 18, 2024
@berryde
Copy link
Contributor Author

berryde commented May 18, 2024

I understand that this is an opinionated change - I think it is best illustrated by the validation example provided in the linked issue:

Before

image

After

image

@berryde berryde changed the title Do not colour FormGroup sub label based on intent [core] fix: do not colour FormGroup sub label based on intent May 18, 2024
@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@CPerinet
Copy link
Contributor

The change makes sense to me

@invliD invliD merged commit 772e44c into develop May 20, 2024
13 checks passed
@invliD invliD deleted the db/sub-label-intent branch May 20, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

Assignees
No one assigned
Labels
Domain: design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it correct for the FormGroup sub label colour to be determined by the intent?
5 participants
@berryde @svc-palantir-github @CPerinet @invliD @svc-changelog