Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormGroup sub label colour diverges from helper text in dark theme, has low contrast #6807

Closed
berryde opened this issue May 18, 2024 · 0 comments · Fixed by #6810
Closed

Comments

@berryde
Copy link
Contributor

berryde commented May 18, 2024

Environment

  • Package version(s): @blueprintjs/core 5.10.3
  • Operating System: Windows
  • Browser name and version: Google Chrome 125.0.6422.60

Example

Link to a minimal repro: https://blueprintjs.com/docs/#core/components/form-group

Steps to reproduce

  1. Enable dark theme(⇧D)
  2. Enable "Show helper text"
  3. Enable "Show sub label"

Actual behavior

The helper text and sub label have the same text colour when using the light theme, but a differ in text colour when using the dark theme. The sub label has very low contrast against the background.

image

Expected behavior

The sub label should have the same colour has the helper text, like when using the light theme:

image

Possible solution

Update the sub label text colour to match the helper text, like so:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant