Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when image names conflict #125

Open
Itangalo opened this issue Mar 12, 2022 · 1 comment
Open

Problems when image names conflict #125

Itangalo opened this issue Mar 12, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Itangalo
Copy link

Describe the bug
I had two images with the same name, in different folders. I could not get paperize to pick up the one I wanted, even pointing (again) to the correct folder and also renaming the other image.

To Reproduce

  1. Upload an image foo.jpg to the image folder. Use it in a component, with dynamic image names.
  2. Create a subfolder "bar" in the Image folder. Upload another image also named foo.jpg to it.
  3. Direct the component to look for images in "bar".
  4. Result: The first foo image is still picked up.
  5. Rename the first foo image.
  6. Result: The first foo image is still picked up.
  7. Clear image cache.
  8. Result: The first foo image is still picked up.
  9. Delete the first foo image from Google Drive. Re-upload with another name.
  10. Result: The second foo image is picked up.

Expected behavior
I don't really know what the expected behaviour should be here. I mean, it's a good thing that I can move around images without connections being broken. But at least when renaming images it would be nice if the connection is broken, since the connection is based on the name of the image.

@Itangalo Itangalo added bug Something isn't working incoming Awaiting triage by a project member labels Mar 12, 2022
@lorennorman lorennorman removed the incoming Awaiting triage by a project member label Mar 22, 2022
@lorennorman
Copy link
Contributor

Interesting one. Perhaps some simple image search result prioritization by weight images that have closer proximity to the game folder you're working would go a long way:

/Paperize/This Game/Images <-- use one from here...
/Paperize/Other Game/Images <-- ...before one found here

at least when renaming images it would be nice if the connection is broken, since the connection is based on the name of the image.

I'm surprised it doesn't get broken if you rename. Oh! If you rename in Drive, you need to click the little "refresh" arrows inside the Drive Explorer on the Paperize side, this refreshes the database and changes the name of the image so it won't match anymore. (Please tell me if this isn't true!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants