Add Golang linting in CI and remove unreachable code from the repo

[akshay196]

Describe the issue you're facing

• There are few unused funcs/packages that need to be removed. Run Golang lint to check other lint errors.
• Add Golang lint job to CI, use https://golangci-lint.run/ or similar

[bhavyastar]

Hey @akshay196 I would like to work on this issue.

[akshay196]

@bhavyastar Thanks for showing interest.
There are quite a few lint errors that we need to fix as part of this issue. At the end we need to enable go lint checker in CI.
With the default linters enabled golangci-lint reports 184 errors.

$ golangci-lint run --out-format json | jq '.Issues | length'
184

Feel free to fix all at once or take a sequential approach. Let us know if you need any help.
Meantime I would like to take a look at different golangci-lint linters (from disabled list) that we can enable for us.

[theluckiesthuman]

@akshay196 Is the issue fixed, or can I work on this?

[akshay196]

@bhavyastar Are you still working on this issue?

[akshay196]

@theluckiesthuman If you're interested, you can get started on this. Let us know if you need anything.

[theluckiesthuman]

@akshay196 Please assign me this.

[karthikmurali60]

@akshay196 can i work on this ?

[akshay196]

@theluckiesthuman Are you still working on this?

[akshay196]

@karthikmurali60 Feel free to take it up and raise PR once done.

[Omkar0114]

Hi @akshay196 I want to work on this issue!

[Omkar0114]

• After running golangci-lint run --fix showing lint errors

• But after this command golangci-lint run --enable-all --fix resolving lint errors automatically? Or we have to do it manually?

[akshay196]

@Omkar0114 You can use automatic fix option of golangci-lint.
We also need to add the golang lint checker in CI (GitHub Actions) so that new changes/PRs are verified for linting errors.

Hope this is clear. Feel free to raise PR.

[Omkar0114]

@akshay196 Sure. I'll raise a PR soon. Also, I want to ask if we create the lint.yaml file separately under .github/workflows, or in go.yaml we can add the lint job?

[akshay196]

@Omkar0114 let's add lint check in go.yml itself.

[Omkar0114]

Cool. Thanks @akshay196

[akshay196]

This issue is open for anyone interested. Partial PR for a reference #253

[jaydee029]

Hi, @akshay196 I would like to work on this.

[akshay196]

Hey @jaydee029 Feel free to start working. No one actively working on it right now.
Let us know if you need any help.

[jaydee029]

@akshay196 I'm assuming we resolve all the linting errors not just the unused func/types error? right?

[jaydee029]

@akshay196 I'm assuming we resolve all the linting errors not just the unused func/types error? right?

If this is true, we would need to make certain structural changes such as error handling, since lot of the errors involved are missing error checks, as well as the way in which for loops are structured etc.

[akshay196]

@jaydee029 sure, lets try to resolve all possible linting errors.
If it is going to be a big change then take iterative approach, fix few errors at first and then others.
Also we need to add CI check for linting so we avoid adding new errors in future.

[akshay196]

@jaydee029 Thanks for your contribution. We have now added golangci-lint to GitHub workflows.
Feel free to start raising PRs to fix lint issues in code.