particle 3.8.0 usb commands return non-zero exit codes

[saisani]

Description

In the latest update of particle-cli to 3.8.0 produces incorrect error codes whenever using particle usb .... The command actually succeeds, but it will return a failure exit code (non-zero).

This issue is not present if switching back to 3.7.0.

Functionality everything is the same, but users will experience issues if they integrate particle-cli into other scripts.

Steps to reproduce

What are the minimal set of steps required to reproduce the issue?

% particle usb dfu
% echo $?

Expected result

What should happen?

After echo $?, the terminal should show 0.

Actual result

What happened?

echo $? actually returns 255

Environment

Tell us about your setup:

• OS: macOS Ventura 13.1
• Node (run node -v): v19.8.1
• NPM (run npm -v): 9.5.1
• Particle CLI (run particle version): 3.8.0