Wrong protocol on local server?

[steveruizok]

When running npx partykit dev, the worker is hosted at three endpoints:

Build succeeded, starting server...
[pk:inf] Ready on http://0.0.0.0:1999
[pk:inf] - http://127.0.0.1:1999
[pk:inf] - http://192.168.0.214:1999

However, the third endpoint (http://192.168.0.214:1999) does not work because the "wss" protocol is used. This makes a server difficult to debug on a local network.

I think the following code is to blame:

partykit/packages/partysocket/src/index.ts

Lines 88 to 92 in 5ba5c33

	(host.startsWith("localhost:") || host.startsWith("127.0.0.1:")
	? // http / ws
	defaultProtocol
	: // https / wss
	defaultProtocol + "s");

I've been unable to successfully patch the code to find out, but that's my guess!

[threepointone]

Great catch, that's probably it. Fix incoming: #683

[threepointone]

Fix available on partysocket@0.0.19 / y-partykit@0.0.12, lemme know if that does the trick!

[steveruizok]

Thanks!

[Vaibhav-npc]

@threepointone

While integrating Docker containers, I encountered an issue where connections default to WSS despite specifying an HTTP URL in PARTY_KIT_URL=http://host.docker.internal:1999.
This behavior seems counterintuitive, especially when explicit protocols are defined by the user. Could we consider enhancing the logic to default to WS when the provided URL begins with HTTP, and only use WSS for HTTPS URLs?

For now, as a workaround, I am specifying explicitly in constructor:

const provider = new YPartyKitProvider(
  Deno.env.get('PARTY_KIT_URL'),
  record.id,
  yDoc,
  { protocol: "ws" }
);

I believe this could improve usability for scenarios involving Docker container connections. Is reopening the issue for further discussion or consideration possible?

[threepointone]

This is a good idea. Happy to take a PR