Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_driver_internal UAC elevation does not work correctly #299

Open
PyroAVR opened this issue Sep 15, 2023 · 1 comment
Open

install_driver_internal UAC elevation does not work correctly #299

PyroAVR opened this issue Sep 15, 2023 · 1 comment

Comments

@PyroAVR
Copy link

PyroAVR commented Sep 15, 2023

I noticed that while deploying libwdi inside a custom application (not using the Zadig frontend), the UAC elevation logic does not correctly detect if the user is an administrator already.
This leads to failed installation due to missing privileges.

Inverting the result of IsUserAnAdmin in install_driver_internal seems to fix the issue.

@pbatard
Copy link
Owner

pbatard commented Jan 5, 2024

Relevant PR is #300.

Thanks for submitting this. This indeed looks like an error in the code, and I'll apply the PR when I get a chance...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants