Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracking] Installer assumes users always enter two custom upstream DNS server even if they enter only one #4783

Open
yubiuser opened this issue Jul 5, 2022 · 1 comment
Open

[Tracking] Installer assumes users always enter two custom upstream DNS server even if they enter only one #4783

yubiuser opened this issue Jul 5, 2022 · 1 comment
Labels
Bug: Confirmed Verified as a bug to be resolved

Comments

@yubiuser
Copy link
Member

yubiuser commented Jul 5, 2022

The whole "Select custom DNS server" part in the installer needs re-working. It assumes, users enter two DNS servers. If I enter only one, both PIHOLE_DNS_1 and PIHOLE_DNS_2 are set to the same address.
@yubiuser yubiuser added the Bug: Confirmed Verified as a bug to be resolved label Jul 5, 2022
@mattpace1
Copy link

Also, when a user enters more than two DNS servers, only the first and last values are shown (as PIHOLE_DNS_1 and PIHOLE_DNS_2 respectively)

@libklein libklein mentioned this issue Jan 5, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Confirmed Verified as a bug to be resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yubiuser @mattpace1