Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should not return zero when lightning exits while processing the task #53384

Closed
zeminzhou opened this issue May 20, 2024 · 4 comments · Fixed by #53381
Closed

should not return zero when lightning exits while processing the task #53384

zeminzhou opened this issue May 20, 2024 · 4 comments · Fixed by #53381
Labels
severity/minor type/bug This issue is a bug.

Comments

@zeminzhou
Copy link
Contributor

zeminzhou commented May 20, 2024 •
edited

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. start tidb cluster
  2. start lightning server
  3. send task to lightning server
  4. send SIGINT to lightning server

2. What did you expect to see? (Required)

lightnng server exit with status 1

3. What did you see instead (Required)

lightnng server exit with status 0

4. What is your TiDB version? (Required)

master
@zeminzhou zeminzhou added the type/bug This issue is a bug. label May 20, 2024
@zeminzhou zeminzhou mentioned this issue May 20, 2024
Merged
13 tasks
@zeminzhou
Copy link
Contributor Author

/cc @lance6716

@lance6716
Copy link
Contributor

kill -9 will not let the program have a chance to handle it.

@zeminzhou
Copy link
Contributor Author

zeminzhou commented May 20, 2024 •
edited

kill -9 will not let the program have a chance to handle it.

sorry, should be SIGINT, not SIGKILL.

@D3Hunter
Copy link
Contributor

required for k8s job, see #53381 (comment)

ti-chi-bot bot pushed a commit that referenced this issue May 21, 2024
@zeminzhou
lightning: when lightning exits while processing the task, it should …
aeafb18 
…return 1 (#53381)

close #53384
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
@zeminzhou @RidRisR
lightning: when lightning exits while processing the task, it should …
99ad498 
…return 1 (pingcap#53381)

close pingcap#53384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: when lightning exits while processing the task, it should return 1 zeminzhou/tidb
3 participants
@lance6716 @D3Hunter @zeminzhou