Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Cernan's internal timescale to be 1ms. #166

Open
blt opened this issue Dec 26, 2016 · 4 comments
Open

Adjust Cernan's internal timescale to be 1ms. #166

blt opened this issue Dec 26, 2016 · 4 comments

Comments

@blt
Copy link
Collaborator

blt commented Dec 26, 2016

Presently cernan operates on a 1 second timescale. The native protocol defines time in ms timescales. Cernan's internal model ought to be adjusted to correspond to its native protocol.

The discrepancy is one of gradual change to the system, clarification of goals and conventions.

This will necessarily require a change to the way we interpret bin_width. We'll need to retain the default of 1 second bin_width.

@blt
Copy link
Collaborator Author

blt commented Jan 22, 2018

I think, absent a hard ask for this, I'm not enthusiastic about the change any longer. 1ms is just as arbitrary as 1s. Closing.

@blt blt closed this as completed Jan 22, 2018
@joedevivo
Copy link

joedevivo commented Feb 9, 2018

It'd be useful to keep receipt-accurate timestamps for loglines

screenshot 2018-02-09 11 30 24

Currently, we're dropping millisecond precision on these events. The text in the log payload still shows the milliseconds, but nobody is searching or sorting based on that information.

@joedevivo joedevivo reopened this Feb 9, 2018
@blt
Copy link
Collaborator Author

blt commented Feb 9, 2018

@joedevivo to confirm, you're pumping logs through Native source into ES sink?

@joedevivo
Copy link

Actually, you can see this with the Console sink just as easily. It all comes down to the Native source scrubbing the millisecond data it receives here: https://github.com/postmates/cernan/blob/master/src/source/native.rs#L165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants