Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage back up to over 95% #411

Open
dparton opened this issue Feb 1, 2018 · 0 comments
Open

Increase test coverage back up to over 95% #411

dparton opened this issue Feb 1, 2018 · 0 comments
Labels
difficulty: moderate help wanted
Milestone
1.0.0 - taurus–li...

Comments

@dparton
Copy link
Contributor

dparton commented Feb 1, 2018

While kcov was broken, cernan's unit test coverage dropped to 91.6%. I have temporarily reduced the project requirement to 91%, but we should also work on improving the coverage to >95% again.
@blt blt added this to the 1.0.0 - taurus–littrow milestone Feb 1, 2018
@blt blt mentioned this issue Feb 2, 2018
Merged
blt pushed a commit to postmates/hopper that referenced this issue Feb 17, 2018
Add a cap on total queue files
5a19806 
This commit adds a `max_disk_files` option to `channel_with_explicit_capacity`
that allows the caller to set the total amount of on-disk consumption.
The caller may choose to loop on a send which results in
`hopper::Error::Full` or drop the data and try again later. Hopper
will _not_ block sends when there is no space available -- in memory
or disk -- to store the item.

This work is done in the service of supporting
postmates/cernan#411 and
postmates/cernan#412.

Signed-off-by: Brian L. Troutwine <blt@postmates.com>
@blt blt mentioned this issue Feb 17, 2018
Merged
blt added a commit to postmates/hopper that referenced this issue Feb 20, 2018
@blt
Add a cap on total queue files (#20)
aa6e1d0 
* Add a cap on total queue files

This commit adds a `max_disk_files` option to `channel_with_explicit_capacity`
that allows the caller to set the total amount of on-disk consumption.
The caller may choose to loop on a send which results in
`hopper::Error::Full` or drop the data and try again later. Hopper
will _not_ block sends when there is no space available -- in memory
or disk -- to store the item.

This work is done in the service of supporting
postmates/cernan#411 and
postmates/cernan#412.

Signed-off-by: Brian L. Troutwine <blt@postmates.com>

* Language update

The language in the README was a touch confusing. If it's still
confusing it's no longer confusing in the same way.

Signed-off-by: Brian L. Troutwine <blt@postmates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: moderate help wanted
Projects
None yet
Milestone
1.0.0 - taurus–littrow
Development

No branches or pull requests
2 participants
@blt @dparton