Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate parse_descriptor_proto() #462

Open
randomdross opened this issue Feb 5, 2019 · 3 comments
Open

Deprecate parse_descriptor_proto() #462

randomdross opened this issue Feb 5, 2019 · 3 comments

Comments

@randomdross
Copy link
Contributor

As per: #461 (comment)
"This is part of the generated protobuf code. It'd be reasonable to regen this and see if the unsafe bits have disappeared. It'd also be willing to open up an issue for deprecation in the next release, removal in the release after."

@blt
Copy link
Collaborator

blt commented Feb 5, 2019

This is a little off the mark. We can't excise a small bit of a piece of generated code. The options are:

  • attempt to regen the code and see if the unsafe block has magically disappeared,
  • merge changes upstream to adjust how code is generated or
  • deprecate the whole protobuf/prometheus reporting subsystem.

@blt blt removed their assignment Feb 5, 2019
@blt
Copy link
Collaborator

blt commented Feb 5, 2019

@randomdross I pulled off my assignment. I'm happy to review patches for this, discuss a deprecation glide path, that said.

@randomdross
Copy link
Contributor Author

No issues w/that, I just wanted to make sure it doesn't fall off the radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants