Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipped/Mirrored Skin Elements flicker severely in the Skin Editor #28237

Closed
SkyJumper409x opened this issue May 19, 2024 · 0 comments · Fixed by #28257
Closed

Flipped/Mirrored Skin Elements flicker severely in the Skin Editor #28237

SkyJumper409x opened this issue May 19, 2024 · 0 comments · Fixed by #28257
Assignees

Comments

@SkyJumper409x
Copy link

Type

Game behaviour

Bug description

This happened to me while skinning, and i can consistently reproduce it, here is how:

  1. Enter Skin Editor
  2. Add any Element
  3. Flip that Element, either vertically, horizontally, or both horizontally and vertically.
  4. Move it around, it might take a little bit of moving, especially for smaller elements.
    the element will start flickering positions along with anchors and origins, sometimes even flicking offscreen. This will stop if the element is no longer being moved.
    I found it to be most severe with horizontal flipping and large elements, especially the ArgonWedgePiece, on the Playfield ("osu!" Only) Layer, and least severe with vertical flipping and small elements like the LegacySongProgress, on the HUD layer.
    I am fairly sure the Element's anchor setting has to be set to "closest".
    I can reproduce this on all Layers (HUD, HUD ("osu!" Only), and Playfield ("osu!" Only))

Screenshots or videos

i recorded a video of about 3 minutes of me triggering the bug with various elements: (youtube link) osuissue.mp4

Version

2024.519.1-lazer

Logs

logs:
compressed-logs-modified.zip
I replaced all occurences of my username in the logfiles with "[username]". I hope this is okay.

@bdach bdach self-assigned this May 20, 2024
bdach added a commit to bdach/osu that referenced this issue May 20, 2024
Closes ppy#28237.

Solution as proposed here:
ppy#28089 (comment)

For flips and rotations by 90 degrees this does what you would expect it
to. For arbitrary rotations it *sort of kind of* attempts to do this but
the results are a bit wonky - probably still better than what was there
before, though?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants