-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ttl
to alertmanagerconfigs
resource
#6360
Comments
IIUC this needs alertmanager version 0.27.0 |
Do you want to contribute to the change? |
Go for it, thanks @aerosouund ! |
@aerosouund sure go ahead :) |
Here is a example PR #5886 how to add fields in alertmanagerconfigs
Incase if you have any questions please feel free to ask |
Hello @slashpai I have created a PR that adds the field, although i'd like to ask you where to add the functionality that uses this field. where do you think this functionality belongs ? or where do i start looking ? |
@aerosouund Alertmanager will be able to pick up the config and use, see the PR that added the functionality to AM here |
You need to add the code to include this change in pkg/alertmanager/amcfg.go, unit test to pkg/alertmanager/amcfg_test.go See the example PR I linked in previous comment |
hi @aerosouund just check in! 😄 Are you still following up with your PR? I wanted to take this up. |
Hey @afzal442 |
Component(s)
AlertManagerConfig
What is missing? Please describe.
A new field was added to the
pushover_configs
calledttl
, it would be nice if the operator supported this new fieldRefs:
Describe alternatives you've considered.
No response
Environment Information.
Environment
Kubernetes Version: v1.29.2
Prometheus-Operator Version: 0.71.2
The text was updated successfully, but these errors were encountered: