You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After doing a git pull, it's possible that there were changes to system dependencies in setup.sh or Python dependencies in pyproject.toml/poetry.lock that need to be updated. If those dependencies don't get updated, things may work fine, or things may break in subtle and hard to reproduce ways. Python dependency updates are much more common than setup.sh updates, so I think this issue should just focus on that.
On startup, pwndbg should check for a file called $PWNDBG_VENV_PATH/poetry.lock.hash or something similar. If it doesn't exist it should create it with with the hash of poetry.lock and run poetry install. If it does exist, it should check if the hash in that file matches the actual hash of poetry.lock. if they differ, run poetry install and update the hash stored in poetry.lock.hash.
For developers, we need to run poetry install -with dev to update dev dependencies. We could maybe store an additional file in $PWNDBG_VENV_PATH marking the user as a developer (created in setup-dev.sh).
The one issue with this is that both normal and dev dependencies are stored in poetry.lock, so if I update a dev dependency the poetry.lock hash will change and poetry install will still get run, even though it wouldn't update anything for regular users. This won't happen very often, and poetry install is pretty fast anyway, so maybe this won't be a problem.
The text was updated successfully, but these errors were encountered:
After doing a
git pull
, it's possible that there were changes to system dependencies insetup.sh
or Python dependencies inpyproject.toml
/poetry.lock
that need to be updated. If those dependencies don't get updated, things may work fine, or things may break in subtle and hard to reproduce ways. Python dependency updates are much more common thansetup.sh
updates, so I think this issue should just focus on that.On startup,
pwndbg
should check for a file called$PWNDBG_VENV_PATH/poetry.lock.hash
or something similar. If it doesn't exist it should create it with with the hash ofpoetry.lock
and runpoetry install
. If it does exist, it should check if the hash in that file matches the actual hash ofpoetry.lock
. if they differ, runpoetry install
and update the hash stored inpoetry.lock.hash
.For developers, we need to run
poetry install -with dev
to update dev dependencies. We could maybe store an additional file in$PWNDBG_VENV_PATH
marking the user as a developer (created insetup-dev.sh
).The one issue with this is that both normal and dev dependencies are stored in
poetry.lock
, so if I update a dev dependency thepoetry.lock
hash will change andpoetry install
will still get run, even though it wouldn't update anything for regular users. This won't happen very often, andpoetry install
is pretty fast anyway, so maybe this won't be a problem.The text was updated successfully, but these errors were encountered: