Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain verification missing #133

Open
yashasvi-ranawat opened this issue Dec 10, 2023 · 2 comments
Open

Chain verification missing #133

yashasvi-ranawat opened this issue Dec 10, 2023 · 2 comments

Comments

@yashasvi-ranawat
Copy link
Contributor

A wallet does not check that the chain (mainnet, testnet or regtest) the output addresses are on matches the one the wallet is on, before sending a transaction.
@merc1er
Copy link
Member

merc1er commented Dec 10, 2023

Does this result in the transaction being rejected by the network?

@yashasvi-ranawat
Copy link
Contributor Author

yes! if you intend to spend a tx on testnet, but accidentally use a mainnet wallet, it won't find the utxos; or worse, send real BCH to a wallet with locking script same as the testnet address.

I saw the Bit repo, it does have a check for such case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yashasvi-ranawat @merc1er