Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculator: input integer overflows when > 0x7FFFFFFF(or 2147483647) #6

Open
liuqun opened this issue Jun 5, 2018 · 0 comments
Open

calculator: input integer overflows when > 0x7FFFFFFF(or 2147483647) #6

liuqun opened this issue Jun 5, 2018 · 0 comments

Comments

@liuqun
Copy link
Contributor

liuqun commented Jun 5, 2018 •
edited

QLCDNumber overflows when input >= 2147483648. (For example: input 9999999999...9)

https://github.com/mfitzp/15-minute-apps/blob/b99eb330310fe7302ead39473ef0d34cccb3d12d/calculator/calculator.py#L62-L67

Since integer has an limit of 0x7FFFFFFF(or 2147483647), casting it into float using self.stack[-1] = float(v) would be better.

Patch code: liuqun@a960653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liuqun