Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch compiler bisect tool #126546

Open
eellison opened this issue May 17, 2024 · 3 comments
Open

torch compiler bisect tool #126546

eellison opened this issue May 17, 2024 · 3 comments
Assignees
Labels
feature A request for a proper, new feature. oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@eellison
Copy link
Contributor

eellison commented May 17, 2024

馃殌 The feature, motivation and pitch

Tool to bisect various parts of the torch.compile stack. As I imagining it, the tool can iteratively go through systems and subsystems. as in:

dynamo
aot_eager
aot_eager_with_decomp: decompositions
inductor: pattern matchings, lowerings, fusions, etc.

There would be a way to interface through CLI, and to do an in-process bisect with a callable. You might also want to bisect to find particular offending graph, not sure how that fits in. Happy to hear input or other suggestions.

cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang

@eellison eellison self-assigned this May 17, 2024
@ezyang
Copy link
Contributor

ezyang commented May 19, 2024

My biggest problem with something that does this in process, automatically, is that I have zero confidence I could reliably ask a user with an fblearner flow to turn on this knob and get something useful. Like, we typically ask people to do an ablation when they're like "oh no, NE explosion". What exactly is your in process bisecter going to do?!

@eellison
Copy link
Contributor Author

For limited iteration speed, probably best way is to bisect offending graph and then save inputs. It should also work out of process.

What is your current MO for NE explosion ?

@xmfan xmfan added the feature A request for a proper, new feature. label May 20, 2024
@ezyang
Copy link
Contributor

ezyang commented May 21, 2024

Pain 馃ぃ

I don't really have more than "do the ablation" and then hand it to the owner of the appropriate area. If it's in Inductor, you can also try ablating optimizations to see if the NE explosion goes away.

@mlazos mlazos added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A request for a proper, new feature. oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

5 participants