Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codestyle: Type Hints (PEP 484) #470

Open
WhiteApfel opened this issue Feb 12, 2023 · 3 comments
Open

Codestyle: Type Hints (PEP 484) #470

WhiteApfel opened this issue Feb 12, 2023 · 3 comments

Comments

@WhiteApfel
Copy link

I want to work on async read/write (WIP #303) and see that there are no type hints in the code. Is it appropriate to add type hints, or is it better to stick with the current style?

@WhiteApfel
Copy link
Author

I do not claim to work on full coverage of type hints, but I would like at least new functions or changed code to have such a convenient option.

@jonasmalacofilho
Copy link
Member

I think type hints are desirable, in general and in this specific project.

But I'm not sure it would be very useful to add them in just a few isolated places (and without our CI actually checking them).

@demberto
Copy link

I could work up on a PR, if one isn't already being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants