Configurable UI appearance and corresponding options page #17524

zeule · 2017-02-08T22:54:05Z

zeule
Feb 8, 2017

Dear @qbittorrent/qbittorrent-frequent-contributors, @magao, @Zalewa,
and everyone interested, of course.

Let's discuss possible implementations for the appearance settings here. It turns out (#6196) various appearance settings may not only be required to satisfy user taste or preferences, but also be a
requirement for a specific environment. Therefore let's try to summaries requirements and desires for those settings.

I quote @magao comment from PR #6196 here:

I'd be willing to implement a new Appearance tab which simply aggregated all the existing appearance options and could then be used as the basis for other PRs to build on. I'll see if I can get to it this weekend.

These are the options I think should be moved to Appearance:

Behaviour/Language (which means Appearance should be the first tab so it's the first thing that shows up when the options opens).

Behaviour/Transfer List/Use alternating row colors

Behaviour/Transfer List/Hide zero and infinity values

Behaviour/Desktop/Show splash screen on start up (not sure about this one - could fit in either category)

Behaviour/Desktop/Start qBittorrent minimized + all sub-options (not sure about this one - could fit in either category)

Behaviour/Desktop/Show qBittorrent in notification area (not sure about this one - could fit in either category)

Advanced/Display notifications

Advanced/Display notifications for added torrents (should this only be available if Display notifications is checked?)

Advanced/Download tracker's favicon (rename to Show tracker's favicon?)

Advanced/Use system icon theme (on linux this only seems to affect the notification area icon - should this only be #if (defined(Q_OS_UNIX) && !defined(Q_OS_MAC))?)

I think a user additionally might want to change:

Fonts for the torrents list, torrent contents tab, log window, RSS reader.
Colours for the torrent list, log window, RSS reader, speed plot, download progress bar.
A user might want to colourise everything in the main window, status icons only, or nothing.

We can provide defaults for colours that depends on an environment (Plasma and Gnome (not really sure) have enough colours in their colour schemes to cover all torrent states).

Referencing related PRs: #3936 #4057 #6156 #6186 #6196

sledgehammer999 · 2017-02-08T22:56:05Z

sledgehammer999
Feb 8, 2017
Maintainer

Copying my #6196 (comment):
IMO, these belong to Behavior:

Behaviour/Transfer List/Hide zero and infinity values
Behaviour/Desktop/Show splash screen on start up
Behaviour/Desktop/Start qBittorrent minimized + all sub-options
Behaviour/Desktop/Show qBittorrent in notification area
Advanced/Display notifications
Advanced/Display notifications for added torrents
Advanced/Download tracker's favicon (although this might be considered truly an advanced option)

Advanced/Use system icon theme (on linux this only seems to affect the notification area icon - should this only be #if (defined(Q_OS_UNIX) && !defined(Q_OS_MAC))?)

Talking from memory here, but I think this also controls the icons for the toolbar and any other icon that follows the icon theme naming spec.

0 replies

zeule · 2017-02-08T22:57:25Z

zeule
Feb 8, 2017
Author

Talking from memory here, but I think this also controls the icons for the toolbar and any other icon that follows the icon theme naming spec.

Confirm.

0 replies

sledgehammer999 · 2017-02-08T22:58:22Z

sledgehammer999
Feb 8, 2017
Maintainer

A user might want to colourise everything in the main window, status icons only, or nothing.

What do you mean by this? Complete skinning support? -I think we'll open a can of worms implementing it-

0 replies

zeule · 2017-02-08T23:01:56Z

zeule
Feb 8, 2017
Author

What do you mean by this? Complete skinning support?

Torrent state colours may be applied to the whole lines in the transfers list (text and icon), to the icon only or not applied at all, leaving icons monochrome too.

0 replies

magao · 2017-02-08T23:05:16Z

magao
Feb 8, 2017

Torrent state colours may be applied to the whole lines in the transfers list (text and icon), to the icon only or not applied at all, leaving icons monochrome too.

Yes - I was thinking that as well. We'd need most of the changes from PR #6186 to do this.

0 replies

sledgehammer999 · 2017-02-08T23:15:13Z

sledgehammer999
Feb 8, 2017
Maintainer

Torrent state colours may be applied to the whole lines in the transfers list (text and icon), to the icon only or not applied at all, leaving icons monochrome too.

Ok, I understand now.

0 replies

zeule · 2017-02-08T23:46:24Z

zeule
Feb 8, 2017
Author

To synchronise our thoughts:

I'm thinking about a couple of singletons that implement respective interfaces (e.g. ColorTheme and FontTheme). Those singletons implement the Bridge pattern using a number of implementations: DefaultColorThemeProvider, CustomColorThemeProvider, PlasmaColorThemeProvider, etc. The same for fonts. The providers returns set of colours/fonts, either predefined or loaded from the config file or obtained from environment. The Theme objects handle enabling/disabling colour/font for a particular UI element returning either specific or default colour/font. The options page allows user to select a theme provider (predefined qBt theme, system, custom) and enable/disable theming of UI element.

@magao, @sledgehammer999: would you agree?

0 replies

magao · 2017-02-08T23:57:49Z

magao
Feb 8, 2017

Sounds reasonable. Think it needs to be done in several steps (PRs):

Consolidate all the existing appearance-related options into a single tab.
Create the new code structure, with just the default providers.
Hook in theme change detection and set up signals.
Start adding new customisation features (colours, fonts, etc).

I'm happy to work on step 1 this weekend. This should be purely a UI task, step 2 could be done in parallel. Do you want to start on step 2 @evsh?

0 replies

zeule · 2017-02-09T00:11:38Z

zeule
Feb 9, 2017
Author

@magao: yes, this makes sense. Would be happy to implement the second task, but will be busy this weekend and not sure yet about the next one.

0 replies

zeule · 2017-02-09T00:16:11Z

zeule
Feb 9, 2017
Author

Another little idea: perhaps we should save colour schemes in a separate file. This would allow us to unify default and custom themes (just by distributing a file with the default theme), move colours specification out of the code and allow users to save and exchange the themes. I can think of a few default ones, like Light, Dark, Solarized...

0 replies

magao · 2017-02-09T00:20:08Z

magao
Feb 9, 2017

~~Sounds good. I could do that as part of step 1.~~ Note sure what I was replying to here - not about saving colour schemes in separate file ...

Step 3 would use bits from my PR #6174. I'd probably change it so the themeChanged() signal was on Preferences, and it would only be sent if one or more of the appearance options changed. We also will need to be careful to make sure that all the providers have been notified before any users of the providers are (currently I'm doing that by directly calling into GuiIconProvider).

0 replies

magao · 2017-02-09T07:46:44Z

magao
Feb 9, 2017

Did a quick implementation of step 1 after work - main issue was moving options around the tabs. QtCreator wasn't much help.

Use system icon theme is hidden except on non-MacOS UNIX. If the Desktop section is empty then it is hidden (implemented that way so if we add other desktop things here it will show automatically)..

All three prefs are migrated to Preferences/Appearance/...

I'm no artist, so I just moved the icon from Behaviour to Appearance, and gave Behaviour the gear. I also changed the WebUI icon to qbt-theme/webui.png which I think it was probably intended to be.

I also want to set up the them change detection and signals before submitting a PR, but does this look like how you want it?

0 replies

birdie-github · 2017-02-09T18:05:33Z

birdie-github
Feb 9, 2017

Let me chime in:

No other existing application implements this (except maybe firefox in about:config) but it would be nice if user modified options were highlighted
While we're at it, it would be nice to have "Reset to default" for each Tab (to the left of Apply/Cancel/OK), which when clicked asked whether the options in the current tab would be reset or all QBitTorrent options to be reset
IMO, the menu structure/organization in QBitTorrent is a tad awkward

I'd have:

File -> Create Torrent
File -> Open Torrent File (instead of "Add")
File -> Open Torrent URL (instead of "Add")

Rename "Edit" to "Torrent" (Edit traditionally means Cut/Copy/Paste)

View is OK.

No "Torrent Create" under Tools (already in "File")

"Lock QBitTorrent" belongs to "Tools" or even "File".

0 replies

glassez · 2017-02-09T18:19:06Z

glassez
Feb 9, 2017
Collaborator

File -> Open Torrent File (instead of "Add")
File -> Open Torrent URL (instead of "Add")

IMO, more correct is "Add Torrent from File" (and "Add Torrent from URL").
Described action: ADDING torrent to session from some source (file or URL).

0 replies

magao · 2017-02-09T20:48:02Z

magao
Feb 9, 2017

From PR #6186 ...

You may return QPalette::color(QPalette::Active, QPalette::WindowText) (or use QPalette::Inactive for stalled torrents, although inactive colours are the same as active on Windows, AFAIK).

Thinking about this - maybe the monochrome text theme should be:

Actively uploading/downloading - > QPalette::Active
Paused/stalled/complete -> QPalette::Inactive

I'll prototype it and see how it looks.

0 replies

thalieht · 2017-02-09T21:41:00Z

thalieht
Feb 9, 2017
Collaborator

Rename "Edit" to "Torrent" (Edit traditionally means Cut/Copy/Paste)

👍

0 replies

zeule · 2017-02-11T14:35:42Z

zeule
Feb 11, 2017
Author

I also want to set up the them change detection and signals before submitting a PR, but does this look like how you want it?

@magao Excuse me, but since you do not show any code and the illustration is obvious, what feedback do you expect?

0 replies

magao · 2017-02-11T20:29:34Z

magao
Feb 11, 2017

@ech @sledgehammer999 Sorry - whether the right options had been moved to the Appearance tab, and if the icon selection was reasonable.

0 replies

allanlaal · 2019-02-22T17:49:31Z

allanlaal
Feb 22, 2019

Advanced/Display notifications for added torrents (should this only be available if Display notifications is checked?)

this is discussed in #7360

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configurable UI appearance and corresponding options page #17524

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 19 comments

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Configurable UI appearance and corresponding options page #17524

Replies: 19 comments

sledgehammer999 Feb 8, 2017 Maintainer

zeule Feb 8, 2017 Author

sledgehammer999 Feb 8, 2017 Maintainer

zeule Feb 8, 2017 Author

sledgehammer999 Feb 8, 2017 Maintainer

zeule Feb 8, 2017 Author

zeule Feb 9, 2017 Author

zeule Feb 9, 2017 Author

glassez Feb 9, 2017 Collaborator

thalieht Feb 9, 2017 Collaborator

zeule Feb 11, 2017 Author

sledgehammer999
Feb 8, 2017
Maintainer

zeule
Feb 8, 2017
Author

sledgehammer999
Feb 8, 2017
Maintainer

zeule
Feb 8, 2017
Author

sledgehammer999
Feb 8, 2017
Maintainer

zeule
Feb 8, 2017
Author

zeule
Feb 9, 2017
Author

zeule
Feb 9, 2017
Author

glassez
Feb 9, 2017
Collaborator

thalieht
Feb 9, 2017
Collaborator

zeule
Feb 11, 2017
Author