Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme #6434

Closed
YodaEmbedding opened this issue Feb 27, 2017 · 194 comments
Closed

Dark Theme #6434

YodaEmbedding opened this issue Feb 27, 2017 · 194 comments
Labels
Feature request Look and feel Affect UI "Look and feel" only without changing the logic

Comments

@YodaEmbedding
Copy link

YodaEmbedding commented Feb 27, 2017

Is there a way to use Qt's theme engine to support themeing? In particular, a simple dark theme option would be great: qBittorrent is blindingly white at night when I want to watch some... legally downloaded TV shows.

P.S. I'm on Windows.


EDIT: I'm on Linux now. Dark themes galore! Join the masterrace, folks!

@smokecrack
Copy link

Ooh would love to see a night mode for qbittorrent. Have just lately tried night mode themes for programs and so much easier on the eyes when room is darker

@Poilaucul
Copy link

Definitely need a dark theme.

@Kirov123
Copy link

Kirov123 commented Mar 4, 2018

I agree, a dark mode or a dark theme with theming support would be fantastic.

@brusfest
Copy link

brusfest commented Mar 7, 2018

Can we get an update on where you've gotten on this? I know a lot of people really would like this feature.

@suratovvlad
Copy link

I haven't update My fork for a long time, however I would appreciate any help.
Also, I have installer for windows and aur repo for archlinux

@oghaki
Copy link

oghaki commented Mar 11, 2018

This is by far the proposed feature I care most about. I would prefer to only have a dark theme over having the extremely bright UI that is currently present.

@Garbonzo17
Copy link

Garbonzo17 commented Mar 11, 2018 via email

@YodaEmbedding
Copy link
Author

Hey guys, could you please stop adding "me too" comments? To show your support, you can thumbs up the request. Thanks!

@realies
Copy link

realies commented Apr 2, 2018

Dark theme for the web interface would also be great.

@5ay3h 5ay3h mentioned this issue Apr 5, 2018
12 tasks
@Wizek
Copy link

Wizek commented Apr 5, 2018

@realies Dark theme for the web interface may actually be the simplest to implement! It's just CSS after all and it's trivial to override. Doesn't even require cooperation of the maintainer(s) or new release of qBittorrent, could be using something like https://userstyles.org/.

Heck, we may even find https://chrome.google.com/webstore/detail/deluminate/iebboopaeangfpceklajfohhbpkkfiaa to be more than adequit for the task, so that only requires a single extension install and not even any code.

It's strange that I'm only now thinking of this option as I use Deluminate daily (nightly?), and was troubled by qBittorrent's bright interface for some time now. I hope to give this a try soon as this seems like our best option so far.

@realies
Copy link

realies commented Apr 5, 2018

No need for third party add-ons/scripts when it can be an option in the settings.

@Wizek
Copy link

Wizek commented Apr 5, 2018

@realies You are reading my comment in reverse.

Of course, if/when it will become an option in the settings then I will likely prefer to use that too.
But the maintainers don't exactly even seem to be keen on merging anyone else's work in this direction, let alone implementing something themselves. So I wouldn't hold our breath for official support any time soon.

And what I am saying could be a solution (workaround?) even in the meantime, that those of us who care about this can start using even today.

@realies
Copy link

realies commented Apr 5, 2018

Cool insight, I would wait for an official implementation.

@Wizek
Copy link

Wizek commented Apr 5, 2018

That's okay. How long do you think you'll have to wait? How long are you prepared to hold out? Or maybe being able to use a dark theme is not very important for you after all?

@realies
Copy link

realies commented Apr 5, 2018

It is not a necessity, but a nice to have due to aforementioned reasons.

If the developers aren't really bothered with implementing a theme system, they could also do with a simple checkbox entitled "night mode" that inserts a filter:invert(100%) class on the html tag.

@Wizek
Copy link

Wizek commented Apr 5, 2018

That's quite exactly what Deluminate does, except it goes a step further with color-correction:

filter: invert(100%) hue-rotate(180deg);

And it has further support for keeping images non-inverted that may or may not be important for the web ui.

@Wizek
Copy link

Wizek commented Apr 5, 2018

There is also this Firefox variety: https://addons.mozilla.org/en-US/firefox/addon/owl/

@GlobalSaffer
Copy link

Yes, please.

@heymaad
Copy link

heymaad commented May 4, 2018

Any updates?

@DrXadium
Copy link

DrXadium commented May 5, 2018

I would be all for just using the web interface with a new skin, but the problem is I rely on the search plugins which (I believe) are still not accessible through the web interface. If I had a way to run those searches as well, then I wouldn't care about waiting for a native dark theme to come to the program on Windows.

@pullup
Copy link

pullup commented May 23, 2018

It's currently blinding me from off to the side on a side monitor. We need dark mode!

@nzec
Copy link

nzec commented May 24, 2018

👍 for a dark mode!

@blu3nh
Copy link

blu3nh commented May 24, 2018

Here's to hoping that it will be implemented

@andrewpros
Copy link
Contributor

andrewpros commented Feb 24, 2020

Stop spamming the same things again and again ppl.
It is already fixed, with that fix it is possible to set any color with theme, it just needs to be released.

@andrewpros
Copy link
Contributor

andrewpros commented Feb 24, 2020

I made you wait. Solarized and ICEBURG are ready.

U did leave the transfer list hover white-ish bg color, it can be changed, it is unusable in this state.
My current working "dark" theme has normal dark transfer list, well a little lighter than the theme as the text colors are fixed.

dark.zip

@maboroshin
Copy link
Contributor

maboroshin commented Feb 24, 2020

@andrewpros : Please count calmly. Within a month, most of me are Q&A (replies). Reporting for logs and link colors. This is probably a new mention.

@theincognito-inc
Copy link

@maboroshin Your iceberg theme is cool. Currently using here:
Iceberg

@omarelmassry
Copy link

@maboroshin i used iceberg theme but it's different than yours I'm not sure why.
Annotation 2020-02-27 012259

@maboroshin
Copy link
Contributor

@omarelmassry : Please come here.

@thapar
Copy link

thapar commented Feb 28, 2020

The solution is to improve the program, not the theme file. I don't know because I'm not involved in the program. But if you look at the logs here, you understand that it is in the near future.

Can you give the link to the logs you are referring to?

@Nan0bit
Copy link

Nan0bit commented Mar 5, 2020

When 4.2.2 comes, I would love to see a theme using the same colors of gray that windows 10 dark mode is using.
Tried changing a couple of colors and this is what I got.
asd

any chance I can get a link to this one?

@epigramx
Copy link

For those that can't wait.

Just get https://github.com/jagannatharjun/qbt-theme/raw/master/mumble-dark.qbtheme

Use it at Tools->Options->Behavior

@Caspy7
Copy link

Caspy7 commented Mar 29, 2020

That's great. Thank you.

Use it at Tools->Options->Behavior

To be more explicit for the non-technical, under Behavior then click the Theme dropdown, "select" and select the file you downloaded.

As an aside, all my "seeding" files are showing with black text on a dark gray background so they're unreadable (unless selected).
I'm on Windows (in case that's the wrench in the works).

@Caspy7
Copy link

Caspy7 commented Mar 29, 2020

Welp. I just updated to the most recent qbittorrent version and that fixed my dark text issue. Sorry for the noise.
Also instructions are different and more obvious for the new version as you just check to "Use Custom Theme UI".

@Goten87
Copy link

Goten87 commented Mar 29, 2020

is there a way to hide the title bar compleety ? its still ugly white :P

@RabidWolf
Copy link

RabidWolf commented Mar 29, 2020

I keep improving. This is the ICEBURG version. If I don't know the theme license, I have to get more icons. e.g. Convert each original icons for dark.
QbIce

@maboroshin I'm using ayudark (rev 3) and all the text colours are grey ie error, downloading and seeding instead of red (error), green (downloading) and whatever colour seeding is meant to be. is it meant to be like that?

Apart from that, great themes. 👍

@Nan0bit
Copy link

Nan0bit commented Mar 30, 2020

is there a way to hide the title bar compleety ? its still ugly white :P

set dark mode system wide in windows

image
image

@gothicserpent
Copy link

gothicserpent commented Mar 30, 2020

BACKGROUND

Theming is implemented currently using .qbtheme files, and with 4.2.2 one of the most prominent developers of a viable dark theme, @jagannatharjun , has updated his repository. Below is a visual example so people can see a preview. Here it is with Name and Save Path text censored to prevent leaking. All the colors are good now and consistent across all columns for each row. Eyes feel okay. Thanks to the dev for his great work!

Jagannatharjun Darkstylesheet.qbtheme with text censored

DOWNLOAD

https://github.com/jagannatharjun/qbt-theme -> Darkstylesheet.qbtheme or
https://github.com/jagannatharjun/qbt-theme/raw/master/darkstylesheet.qbtheme for a direct link.

INSTALLATION

  1. Menu->Tools->Options->Behavior->Interface->Use custom UI Theme: select .qbtheme file
  2. Restart QBittorrent for the .qbtheme to take effect

image

@FranciscoPombal
Copy link
Member

There are now wiki pages documenting this (they are also reachable from the wiki homepage):
https://github.com/qbittorrent/qBittorrent/wiki/How-to-use-custom-UI-themes
https://github.com/qbittorrent/qBittorrent/wiki/List-of-known-qBittorrent-themes

Thanks @gothicserpent

@FranciscoPombal
Copy link
Member

I am tempted to mark this as resolved, as I think it has been sufficiently addressed. There is now at least one usable unofficial dark theme that Windows users can use.

  • Linux users are already covered by their system-wide themeing support (shout-out to the Linux masterrace!)
  • I think Qt already supports macOS's native dark theme, so macOS users are covered as well
  • In the future, Qt will also probably support the native Windows 10 dark theme, and we can open a blank issue just to track that as a Qt bug until it is available.

Please correct me if I am wrong or if anyone has additional concerns.

@Ansem93
Copy link

Ansem93 commented Mar 31, 2020

Please, before closing it add a web dark interface. I get that is possible to add a custom webui, but it's really complicated to do that, even more when you run qbittorrent on docker.

@FranciscoPombal
Copy link
Member

Please, before closing it add a web dark interface. I get that is possible to add a custom webui, but it's really complicated to do that, even more when you run qbittorrent on docker.

This is unrelated to the topic at hand, and should be handled in it's own topic.

@ArekPiekarz
Copy link

ArekPiekarz commented May 26, 2020

@FranciscoPombal What do you mean by "Linux users are already covered by their system-wide themeing support"? I'm on Xubuntu 19.10 and qBittorrent does not follow the system theme, it displays white background and black text instead of Adwaita Dark colors. I'm using the app in version 4.1.7.

@FranciscoPombal
Copy link
Member

@ArekPiekarz firstly, you should be using the latest version, not 4.1.7. Since you are on Ubuntu, you can just install the official PPA: https://launchpad.net/~qbittorrent-team/+archive/ubuntu/qbittorrent-stable

On Ubuntu, for themes to apply to Qt apps, you need to install this package: qt5-style-plugins

@xavier2k6
Copy link
Member

@jagannatharjun could you look into this (if not too much to ask) to expose/use Qt 5 dark Fusion theme?

Qt 5 dark Fusion theme

@melroy89
Copy link

melroy89 commented Sep 18, 2020

Under Linux I can't get the qbtheme files working. It is just me or? I download a dark theme (eg. mumble-dark.qbtheme) select that file at preferences -> Behaviour. Check the box 'Use custom UI theme' as well. And required QBittorrent several times. No success 👎 I'm using Linux Mint 20.

Anybody suffering from the same issue??

@AdKiller
Copy link

I've been using Windows High Contrast theme for years and it works fine. The good thing is it covers almost all apps and websites in Firefox. It is a must have for use at night.

@FranciscoPombal
Copy link
Member

Update to my previous comment (#6434 (comment)):

In the future, Qt will also probably support the native Windows 10 dark theme, and we can open a blank issue just to track that as a Qt bug until it is available.

Qt 5.15 onward (which is used in Windows builds of qBittorrent >= 4.3.0) has support for the native Windows 10 (>= version 1903) dark theme. As of Qt 5.15, it is still experimental, but can be enabled by adding the darkmode=2 windows platform argument to the qt.conf file in the installation directory (these arguments are comma-separated; text after ; is considered a comment and is ignored). Example with several arguments:

[Platforms]
WindowsArguments = dpiawareness=1,fontengine=freetype,darkmode=2

So now all platforms are covered. Here is a PR enabling this by default, so that manually editing qt.conf will no longer be necessary in the future: #13952.

@qbittorrent qbittorrent locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature request Look and feel Affect UI "Look and feel" only without changing the logic
Projects
None yet
Development

No branches or pull requests