Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges *MUST* be directly inside the Gamify/Badges directory #23

Open
abetwothree opened this issue Dec 11, 2019 · 3 comments
Open

Badges *MUST* be directly inside the Gamify/Badges directory #23

abetwothree opened this issue Dec 11, 2019 · 3 comments

Comments

@abetwothree
Copy link
Contributor

abetwothree commented Dec 11, 2019

This is not a complaint but can be a suggestion.

I spent around an hour and half wondering why badges wouldn't work until I looked at the code in the service provider and realized that badges MUST be directly inside the Gamify/Badges directory. They cannot be inside folders within this directory.

So my suggestion is that this could be in the docs for anyone else running into this or the code can be changed a little bit to be able to dig into any folder structure within the Gamify/Badges directory.

Adding the folder structure search would be especially helpful for any larger app that has lots of badges and would like to organize them in folders within the Gamify/Badges directory.

Thank you for taking the time to read this!

@saqueib
Copy link
Member

saqueib commented Dec 13, 2019

@skatetdieu that's a great suggestion. I would love a PR to support nested folders if you can.

@abetwothree
Copy link
Contributor Author

Hi @saqueib, I have made a pull request with the code that would find badges recursively. #24

@abetwothree
Copy link
Contributor Author

Hello, just wondering if there's any updated on this recursive looking for badges. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants