Don’t create storage folder if not needed #51837
Merged
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinko
reviewed
May 17, 2024
jeromedalbert
force-pushed
the
no-storage-if-not-needed-1
branch
from
86820fa
to
12985f3
Compare
The storage/ directory is used for sqlite or Active Storage. If using a different database and the --skip-active-storage option, this directory is not needed.
jeromedalbert
force-pushed
the
no-storage-if-not-needed-1
branch
from
12985f3
to
918c71f
Compare
4 tasks
yahonda
approved these changes
May 20, 2024
rafaelfranca
pushed a commit
that referenced
this pull request
May 21, 2024
Don’t create storage folder if not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #51835.
This Pull Request has been created because the
storage/directory seems to be used only for sqlite orActive Storage. If using a different database and the
--skip-active-storageoption, this directory does not seem like it is needed.Detail
This Pull Request changes the rails app generator to not create the storage directory if skipping Active Storage and using a database that is different from sqlite.
Additional information
The condition I implemented is the same as the one used further down in the generator.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]