Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure files starting on a new piece aren't marked complete twice #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kannibalox
Copy link

@stickz
Copy link
Contributor

stickz commented Oct 5, 2023

This pull request has a regression where completion on the file list is reported as less than 100% when completed.

@kannibalox
Copy link
Author

kannibalox commented Oct 6, 2023

Is there any further information you can provide? The size and order of the files in question and the piece size would be great. I tried a bunch of things, including setting some of the files to "off" priority, but was unable to reproduce.

Edit: Was able to reproduce, will dig in

@kannibalox
Copy link
Author

That should cover all cases, including zero-length files, but I'll do further testing and maybe even take a stab at unit tests to prove it out.

@stickz
Copy link
Contributor

stickz commented Oct 6, 2023

Thanks. I'm working on pushing some of these fixes to various vendors. I backported changes from jesec as well.

@stickz
Copy link
Contributor

stickz commented Dec 7, 2023

This pull request is still broken. Here's an example where the file completion percentage reports incorrectly.
swizzin/swizzin#1106

Running the same code with a patch.
https://github.com/swizzin/swizzin/blob/master/sources/patches/rtorrent/piece-boundary-fix-0.13.8.patch

@kannibalox
Copy link
Author

Very strange, I made sure to test what this condition at least looks to be and it functions correctly, I'll have to find a way to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

200% complete
2 participants