Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagewriter: Disable customisation of custom IMGs #832

Closed
wants to merge 1 commit into from

Conversation

tdewey-rpi
Copy link
Collaborator

Resolves #831 by not offering customisation for custom image sources.

We have no associated metadata for these images, so customisation isn't something we can offer in a clear and easy to understand way.

@XECDesign
Copy link

I can't be the only one who frequently flashes Raspberry Pi OS from previously downloaded images. If somebody flashes a random image and find that the customisations don't apply, I think the problem is with that image rather than the imager.

@tdewey-rpi
Copy link
Collaborator Author

While I would generally agree, @XECDesign, the problem here is that we can't communicate that failure to the user in a clear and concise manner.

As #831 demonstrates, users will blame rpi-imager even when the image creator has admitted a fault in their guide or their set up.

Let me talk to you offline about a way around this particular issue that I think you might appreciate.

@cillian64
Copy link
Collaborator

I'm with Serge on this one, especially because image files are the only way to keep a consistent version and are the only option when working offline.

I do think it would be useful to have a warning message when applying customisation to image files that results may be unexpected if it's not an rpi-os image. There will probably be occasional bug reports nonetheless but I reckon the complaints are outweighed by the people relying on this.

If this does really need solving, could we come up with a simple way to identify whether image files are rpi-os, ubuntu server, or something else? (a way which doesn't involve adding a new identifier and so works on old image files).

@tdewey-rpi
Copy link
Collaborator Author

Discussed offline, I'm going to withdraw this and submit an alternative.

The alternative will, rather than completely removing customisation, provide an alternative additional dialog that asks you to confirm the OS is either Raspberry Pi OS or Ubuntu Server. If you select neither, customisation will not be offered.

@tdewey-rpi tdewey-rpi closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Existing users are overwritten when applying custom settings
3 participants