Shader binding and matrix calculations inside loop.

[ghost]

Hello again.

This concerns the block of code at:

raylib/src/rlgl.h

Line 2380 in 226c0e3

glUseProgram(RLGL.State.currentShaderId);

           // Set current shader and upload current MVP matrix
            glUseProgram(RLGL.State.currentShaderId);

            // Create modelview-projection matrix and upload to shader
            Matrix matMVP = rlMatrixMultiply(RLGL.State.modelview, RLGL.State.projection);
            float matMVPfloat[16] = {
                matMVP.m0, matMVP.m1, matMVP.m2, matMVP.m3,
                matMVP.m4, matMVP.m5, matMVP.m6, matMVP.m7,
                matMVP.m8, matMVP.m9, matMVP.m10, matMVP.m11,
                matMVP.m12, matMVP.m13, matMVP.m14, matMVP.m15
            };
            glUniformMatrix4fv(RLGL.State.currentShaderLocs[RL_SHADER_LOC_MATRIX_MVP], 1, false, matMVPfloat);

This code is run inside a loop, eventhough none of the values involved rely on anything defined in the loop.
This means this code can be moved out of the loop and it will still work as intended.

Also not a bug, and outside of Stereo rendering, this won't have any effect. But when doing stereo rendering, we are binding the shader program and computing/uploading the MVP matrix twice without any benefit.

[ghost]

Some more uniforms are set a few lines down at:

raylib/src/rlgl.h

Line 2414 in 226c0e3

glUniform4f(RLGL.State.currentShaderLocs[RL_SHADER_LOC_COLOR_DIFFUSE], 1.0f, 1.0f, 1.0f, 1.0f);

These can also be moved out of the loop.

[raysan5]

@hexaflex Actually RLGL.State.modelview and RLGL.State.projection depend on:

    // Set current eye view offset to modelview matrix
    rlSetMatrixModelview(rlMatrixMultiply(matModelView, RLGL.State.viewOffsetStereo[eye]));
    // Set current eye projection matrix
    rlSetMatrixProjection(RLGL.State.projectionStereo[eye]);

In any case, the overhead of calling those functions for one or two eyes is minimal so I prefer to keep all the code inside the loop.

[ghost]

RLGL.State.modelview and RLGL.State.projection depend on ...

I cant believe I missed that. Thanks.