-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negative interval number #4415
Comments
@Kaiyrgali previous to what, can you give more details? What version did this happen in, what version are you using? Can you create a codesandbox example of what you had that worked, vs what does not work now? |
@ckifer The problem probably starts with a pull request #3392 For example, in recharts version "2.0.6" the Y axis is thinned out with negative interval values The latest version already has a problem |
That helps, thanks! The problem is that this was undocumented behavior that the current maintainers didn't know existed and it wasn't in any test cases. Not allowing a negative number makes sense logically, so that's what was done. We should give a way back to you to accomplish the same end result if possible @nikolasrieble any thoughts on this? |
Thank you for reporting this. I likely introduced the bug some time earlier.
In this mental model, I do not understand what a negative interval means. What would the difference be between
|
interval = -1 all ticks were hidden |
@nikolasrieble Thank you for your work and the changes you have made. Unfortunately, we noticed a slight incompatibility with previous setting of the CartesianAxis. Previously, they could take negative values and thereby thin them out from the end of the tick array. Now interval only accepts numbers from zero and above
<YAxis interval={-2} />
does not workThe text was updated successfully, but these errors were encountered: