Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to contribute due to legacy toolchain 'DynamicJsonBuffer is a class from ArduinoJson 5' #19

Open
nuschpl opened this issue Apr 29, 2024 · 0 comments

Comments

@nuschpl
Copy link

nuschpl commented Apr 29, 2024

Hello
I've tried to follow the guide and add depdendencies:


    ArduinoJson library 5.13.1 by Benoit Blanchon
        https://github.com/bblanchon/ArduinoJson
    ESP8266FtpServer.h
        https://github.com/exploitagency/esp8266FTPServer/tree/feature/bbx10_speedup

Added the first lib directly from Arduino IDE, and the second via exported ZIP file of above URL. This resulted in compilation error:

In file included from /Users/User/src/ESP-RFID-Tool/Source Code/esprfidtool/esprfidtool.ino:605:
/Users/User/src/ESP-RFID-Tool/Source Code/esprfidtool/api.h:43:11: error: DynamicJsonBuffer is a class from ArduinoJson 5. Please see https://arduinojson.org/v7/upgrade-from-v5/ to learn how to upgrade to ArduinoJson 7
   43 |   DynamicJsonBuffer jsonAPIbuffer(bufferSize);

So my question is are those custom library variants really needed, can we make anything that software will be more maintanable ? I'm Arduino newbie but is there no way to add those dependencies as a reference to Sketch file instead of encouraging developer to manually do so ? This way this could could still be contributed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant