The old problem has reappeared in the latest version 1.2.4. (ddns ip address not updated)

[zhangbo8418]

Bug Description

The 1.2.4 not work after router restarts (ip changed, DDNS) for self-hosting.The old problem has reappeared in the latest version 1.2.4.

How to Reproduce

#751

Expected Behavior

#751

Operating system(s) on local side and remote side

all

RustDesk Version(s) on local side and remote side

1.2.4

Screenshots

Additional Context

No response

[zhangbo8418]

The problem started with this commit 46b4e21.

[rustdesk]

Orignally it pings every second when network failure, now it pings every 30 seconds when network failure.

[rustdesk]

Pinging very 1 second give our public server big pressure, so we do this change.

[bigretromike]

if server is behind ddns (aka dynamic IP), each time you turn router off you can get different IP. You/Client need to update DNS before its able to connect to server. Most dns servers and even OS are caching dns query also it depend from you ddns client configuraiton - if its time base (15minut delays), event based (eth down/up) or other. Your ddns provider need to update his DNS, then that information need to get to You or your clients.

If you have issue with connecting to server with client can you ping (resolve) ddns name and see if its pointing to your new IP ?
The only issue I could potentialy see here is that rustdesk cache dns - but its easy to check (ping ddns after change), if your OS see your new IP address under your ddns name, and rust cant connect then its rust issue. if your os dont resolve it correctly then its infrastructure issue and not a rust bug.

[zhangbo8418]

if server is behind ddns (aka dynamic IP), each time you turn router off you can get different IP. You/Client need to update DNS before its able to connect to server. Most dns servers and even OS are caching dns query also it depend from you ddns client configuraiton - if its time base (15minut delays), event based (eth down/up) or other. Your ddns provider need to update his DNS, then that information need to get to You or your clients.

If you have issue with connecting to server with client can you ping (resolve) ddns name and see if its pointing to your new IP ? The only issue I could potentialy see here is that rustdesk cache dns - but its easy to check (ping ddns after change), if your OS see your new IP address under your ddns name, and rust cant connect then its rust issue. if your os dont resolve it correctly then its infrastructure issue and not a rust bug.

Of course, I know that the current problem is that it will not reconnect to the server when it is unattended. The previous version did not have this problem. . . Also, when switching IP, that is, when opening the RustDesk client, it will try to connect to the server, and then fail. After failure, it will say that it is not ready. When DDNS is normal, it will not try to connect again, and the client service must be restarted. . .

[rustdesk]

As post previously, it did not stop reconnecting, just changed the reconnecting frequency. We did add something here to test if retry after network failure, it does work as expected.

[rustdesk]

I guess I find the submission.

[rustdesk]

this commit 7e93a5d

[rustdesk]

I have a fix 0f3db29, please try it later, I have trigger the new build action. https://github.com/rustdesk/rustdesk/actions/runs/8090609914

[zhangbo8418]

It seems to be OK.

[rustdesk]

Thanks for your patience.