Encode Color Inaccurate

[slm-sean]

Bug Description

We have noticed that the color accuracy of the video feed is inaccurate. When comparing any of the codec options with the newest nightly build with 4:4:4 color encoding enabled to Teradici PCoIP, we see color inaccuracy with the rustdesk remote connection. I am including screenshots of the rustdesk encode and the Pcoip encode.

How to Reproduce

Color inaccurate with every codec and with 4:4:4 color sample enabled or disabled.

Expected Behavior

Color to be accurate

Operating system(s) on local side and remote side

Rocky Linux 9.3 ->MacOS

RustDesk Version(s) on local side and remote side

Nightly 1.2.4 Nov 23rd 2023 -> Nightly 1.2.4 Nov 23rd 2023

Screenshots

Rustdesk nightly AV1 4:4:4

Teradici PCoIP

Additional Context

No response

[21pages]

maybe related to color space

[slm-sean]

I am trying to find out what color space X11 is using in rocky 9.3. Do you happen to know where i could locate that information? My xorg config files do not specify a color space.

[slm-sean]

My teradici connection appears to be using BGRA according to the session information. What does rustdesk use by default?

[rustdesk]

@21pages what is the conclusion?

[21pages]

No conclusion yet, it may related to 601 or 709, full range or limited range. On my computer there is not a lot of inaccuracy in the blue color, this issue is worth studying, I'll back to this issue soon.

[21pages]

Thanks for your feedback, there is indeed a difference of one or two pixel values, most colors of anydesk are correct, here is the test result, https://github.com/21pages/test/releases/download/test/color.zip, I'll try to fix it.

[21pages]

When using macOS for control and being controlled, color inaccuracies may occur, which are related to system settings. However, when I changed the option System Settings -> Displays -> Color profile to sRGB, Chrome's colors became accurate, and the color discrepancies in RustDesk are also within the normal range. You can use macOS's system tool, Digital Color Meter, to test if the browser's color display is correct. If it's not, it is likely due to an incorrect Color profile.

[rustdesk]

However as controlling side, our mac Sciter version does not have this problem, no need to change display settings. So as controlling side, Flutter rendering (we reproduced this with simple demo) causes this problem. We will work on this issue later on after finishing more urgent issues.

[rustdesk]

A similar scenario (sRGB on mac) is HDR on windows, #5368