-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Paste not working in one direction (Remote -> Local) #6859
Comments
Signed-off-by: fufesou <shuanglongchen@yeah.net>
@bilago Please try the tmp build here https://github.com/fufesou/rustdesk/releases/tag/tmp Install or run it on the remote side.
Only some logs prefixed with "REMOVE ME ====== " are added. Please check if there're some logs there. |
every single time I do CTRL+C |
Thanks! Clipboard transfer in the new build of 1.2.4 works again. Tested against server running 23.10 and 1.2.3 and later updated server to the same release of 1.2.4. Both working. |
@bilago Thank you for your patient testing. It seems RustDesk cannot detect content of the clipboard or there's something wrong. Can you please download the build, and try again? https://github.com/fufesou/rustdesk/releases/tag/tmp I've added more logs about the errors. Please "Ctrl + C" text content, or it will continuously print the following log.
|
@fufesou thanks for all your help so far, I just installed this version and I get this non stop in the logs:
|
@fufesou build a version output the format. |
@bilago Hi, please try https://github.com/fufesou/rustdesk/releases/tag/tmp again. I've add the available clipboard formats. Please copy text and then check what it report in the log. |
|
CF_UNICODETEXT is exactly 13. I cannot understand why Can you please do the following tests?
|
@fufesou
I reversed connection and clipboard is working in both directions without any errors. |
Did you copy some text between these two logs? It seems the "system user service" affects reading the clipboard on your machine, maybe because of some system settings. If so, I can hardly do more changes. Can you please try again? Do not install on the remote side, connect to the remote, then You may find logs in |
This code https://github.com/dacap/clip/blob/94693e2414a2c69a8ca16f065240c80a94cc6221/clip_win.cpp#L289 seems better, better lock/unlock behavior. In https://github.com/1Password/arboard/blob/77e0e078eb460ac2fa0eda96124163c11ef6b2d1/src/platform/windows.rs#L493, size() and data copy not embrased in the same lock, though there is a comment saying no problem, but doubtful. Also it check CF_UNICODETEXT only, do not check the other text format. Another clue:
Currently, on the remote machine, the system service running with user session token can
What will we do?
|
@bilago Hi, can you please try https://github.com/fufesou/rustdesk/releases/tmp again? Thanks. I've used https://github.com/dacap/clip as the clipboard implemantion on Windows. |
@bilago could you test above? |
@fufesou with your latest tmp build, clipboard is not working from remote, and no logs indicating anything either C:\Windows\ServiceProfiles\LocalService\AppData\Roaming\RustDesk\log\server\RustDesk_rCURRENT.log on the remote |
Thanks @bilago , We will have to go to step 2. :(
|
I do appreciate all the time spent on this, I look forward to future developments on the issue. |
tracked by #7342 |
Bug Description
Running nightly on both machines, I can copy paste from my local machine to the remote machine but not in the other direction.
I've enabled/disabled clipboard on both, rebooted, and no change.
File copy from Remote to local is working
no data in my logs for rustdesk to indicate any issues, any way to make it more verbose ?
How to Reproduce
Remote into computer
Select text on remote computer
Press ctrl+C
Focus to local computer
Press ctrl+V
No text pasted, or previous clipboard from local pasted
Expected Behavior
Clipboard should transfer text to local machine
Operating system(s) on local side and remote side
Windows 11 -> Windows 10
RustDesk Version(s) on local side and remote side
1.2.4 -> 1.2.4
Screenshots
n/a
Additional Context
No response
The text was updated successfully, but these errors were encountered: