Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] files paths in the patch not always correctly parsed #445

Open
robang74 opened this issue Jul 2, 2023 · 4 comments
Open

[Bug] files paths in the patch not always correctly parsed #445

robang74 opened this issue Jul 2, 2023 · 4 comments
Labels
bug something that needs fixing

Comments

@robang74
Copy link

robang74 commented Jul 2, 2023

SailFish OS version: 4.5.0.9
Patchmanger Version: 3.2.9
Hardware: Xperia 10 II

BUG DESCRIPTION

Referring to this patch (untested code):

this is the output in the log when the patch is installed:

void PatchManagerObject::doRefreshPatchList() Collecting info for:  "zram-swap-resize-script"
void PatchManagerObject::doRefreshPatchList() Possible conflict in:  "/usr/bin/zram_swap_resize.sh"

and this the same when it is not installed:

void PatchManagerObject::doRefreshPatchList() Collecting info for:  "zram-swap-resize-script"
void PatchManagerObject::doRefreshPatchList() Possible conflict in:  "/zram_swap_resize.sh"

in the second case the patch files paths parsing is wrong, unless I created that file which does not exist by default.

STEPS TO REPRODUCE

  1. download from Web Catalog the patch above
  2. switch the Patch Manager to developer mode
  3. then enable and disable the patch
  4. check the Patch Manager log

ADDITIONAL INFORMATION

Proposed bug-fix

Let me know and I will do a pull/merge request.

@robang74 robang74 added the bug something that needs fixing label Jul 2, 2023
@CODeRUS
Copy link
Contributor

CODeRUS commented Jul 21, 2023

Please take care to fix the code issues reported by this person, but create your own changes. no commits authored by this person are allowed to be merged in this repo.

@CODeRUS
Copy link
Contributor

CODeRUS commented Jul 21, 2023

@nephros @nephros @Olf0 fyi

@Olf0
Copy link
Contributor

Olf0 commented Jul 22, 2023

@b100dian was missed.

@Olf0
Copy link
Contributor

Olf0 commented Jul 22, 2023

Please let us carry out this meta-discussion at the oldest bug report filed by robang74: #444

Every thing discussed there an the meta-level is sure applicable to the filed issues #445 and #446, too (plus any future ones by robang74).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something that needs fixing
Projects
None yet
Development

No branches or pull requests

3 participants