Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language codes not following ISO standards in lang-id-voxlingua107-ecapa #2396

Open
FredHaa opened this issue Feb 7, 2024 · 2 comments · May be fixed by #2565
Open

Language codes not following ISO standards in lang-id-voxlingua107-ecapa #2396

FredHaa opened this issue Feb 7, 2024 · 2 comments · May be fixed by #2565
Labels
bug Something isn't working

Comments

@FredHaa
Copy link

FredHaa commented Feb 7, 2024

Describe the bug

In the tokenizer, Hebrew is given the language code 'iw' and Javanese is given 'jw'. These language codes are incorrect according to the ISO standard

'iw' has been obsoleted and changed to 'he' and 'jw' was an error from the first version of the ISO639 standard, and has latter been corrected to 'jv'.

Expected behaviour

That the correct language codes for Hebrew and Javanese were returned.

To Reproduce

No response

Environment Details

No response

Relevant Log Output

No response

Additional Context

No response

@FredHaa FredHaa added the bug Something isn't working label Feb 7, 2024
@asumagic
Copy link
Collaborator

asumagic commented Apr 8, 2024

Seems like the problem originates from the VoxLingua107 dataset itself, though it can be corrected in the label_encoder.txt file used at inference.

Considering changing this on existing models could break existing code, adding a notice in the relevant documentations would make sense.

@asumagic
Copy link
Collaborator

asumagic commented Jun 6, 2024

Created PR for speechbrain/lang-id-voxlingua107-ecapa: https://huggingface.co/speechbrain/lang-id-voxlingua107-ecapa/discussions/7

Will also create a PR in the recipe documentation in the main repo and link it to close this issue.

@asumagic asumagic linked a pull request Jun 6, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants