Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Introduce WorkflowUICommon #1168

Open
dhavalshreyas opened this issue May 18, 2020 · 3 comments
Open

Proposal: Introduce WorkflowUICommon #1168

dhavalshreyas opened this issue May 18, 2020 · 3 comments
Labels
swift Affects the Swift library.
Milestone

Comments

@dhavalshreyas
Copy link
Contributor

dhavalshreyas commented May 18, 2020

A few container Screen that are currently in Samples, would be better situated with an independent dependency. This will enable easy consumption of these common UI containers.

Containers in Samples currently:

  • AlertContainer
  • BackStackContainer
  • ModalContainer

Possible future additions:

  • TabBarScreen [swift] [rfc] Add TabBarScreen Sample #1098
  • EquatableScreen - A Screen that updates it's rendering only if it's contents have changed.
  • ViewControllerLifecycleObserverScreen - A Screen that has callbacks for some common UIViewController lifecycle events.

Proposal

Move container Screens from Samples to WorkflowUICommon and add WorkflowUICommon.podspec in root. Publish WorkflowUICommon.podspec to Cocoapods.

@dhavalshreyas dhavalshreyas added the swift Affects the Swift library. label May 18, 2020
@dhavalshreyas dhavalshreyas added this to the v1.0.0 milestone May 18, 2020
@AquaGeek
Copy link
Contributor

IIRC, they're in Samples currently because we explicitly don't want them to be added as dependencies elsewhere — they're just guideposts to help others build their own containers. Outside of that, are we willing to take on the maintenance burden of these, given we use parallel implementations internally?

@dhavalshreyas dhavalshreyas modified the milestones: v1.0.0, post-v1.0.0 Jun 8, 2020
@AquaGeek
Copy link
Contributor

One of the suggestions @bencochran brought up internally was the option of us publishing the structs for these Screens (instead of both the struct and the UIViewController) and allowing folks to add the conformance to Screen themselves (BYO view controller). That would at least let us close the gaps between these samples and our own internal versions.

@zach-klippenstein
Copy link
Collaborator

I believe this is the approach we're currently using in kotlin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift Affects the Swift library.
Projects
None yet
Development

No branches or pull requests

3 participants