Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you utilize MMR for UmpireBot - MLB Rules For Baseball #49

Open
abishpius opened this issue Jul 5, 2023 · 0 comments
Open

Could you utilize MMR for UmpireBot - MLB Rules For Baseball #49

abishpius opened this issue Jul 5, 2023 · 0 comments

Comments

@abishpius
Copy link

Would it be possible to update the document search to utilize MMR (Max marginal relevance) instead of this?
relevant_context = search_elements(question, k = 1 + 3int(10(1-closest_match)))

I want to say it will be better at grabbing more context for more ambiguous questions, but will leave final decision to you.

Relevant notebook: https://github.com/statmike/vertex-ai-mlops/blob/main/Applied%20GenAI/Vertex%20AI%20GenAI%20For%20Document%20Q%26A%20v2%20-%20MLB%20Rules%20For%20Baseball.ipynb

Details on MMR (https://python.langchain.com/docs/modules/model_io/prompts/example_selectors/mmr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant