Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a graceful way to terminate st-util #1395

Merged
merged 2 commits into from
May 29, 2024
Merged

Added a graceful way to terminate st-util #1395

merged 2 commits into from
May 29, 2024

Conversation

AJ528
Copy link
Contributor

@AJ528 AJ528 commented May 11, 2024

if st-util is requested to close using SIGTERM, do so and exit with status code 0.

@AJ528 AJ528 marked this pull request as ready for review May 11, 2024 17:56
@Nightwalker-87 Nightwalker-87 linked an issue May 12, 2024 that may be closed by this pull request
[feature] Adding a graceful way for st-util to exit #1396
Closed
1 task
@Nightwalker-87 Nightwalker-87 added this to the v1.8.1 milestone May 12, 2024
@Nightwalker-87 Nightwalker-87 changed the title add a graceful way to terminate st-util Added a graceful way to terminate st-util May 12, 2024
@Nightwalker-87 Nightwalker-87 changed the base branch from develop to testing May 12, 2024 19:31
Ant-ON
Ant-ON suggested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@Ant-ON Ant-ON left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With such changes, (void)signum; is not required

@AJ528
Copy link
Contributor Author

AJ528 commented May 13, 2024

With such changes, (void)signum; is not required

I'll be honest, I don't really know what that line is doing. It comes after exit() so I'm assuming it never gets run. In the spirit of "change as few things as possible" I didn't modify it, but if it serves no purpose I'm happy to remove the line.

@Ant-ON
Copy link
Collaborator

Ant-ON commented May 13, 2024

@AJ528 this line suppress the warning about signum argument not used.

@AJ528
Copy link
Contributor Author

AJ528 commented May 13, 2024

alright, I removed (void) signum;

@Nightwalker-87 Nightwalker-87 merged commit 3520d73 into stlink-org:testing May 29, 2024
10 checks passed
@stlink-org stlink-org locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ant-ON Ant-ON Ant-ON approved these changes

@Nightwalker-87 Nightwalker-87 Nightwalker-87 approved these changes

Assignees

@AJ528 AJ528

Labels
bug/fixed component/st-util status/resolved
Projects
Release v1.8.1
Status: Done
Milestone
v1.8.1
Development

Successfully merging this pull request may close these issues.

[feature] Adding a graceful way for st-util to exit
3 participants
@AJ528 @Ant-ON @Nightwalker-87