Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketing text contents are being cut off #26392

Closed
2 tasks done
pasimuno-ako opened this issue May 16, 2024 · 11 comments
Closed
2 tasks done

Marketing text contents are being cut off #26392

pasimuno-ako opened this issue May 16, 2024 · 11 comments
Labels
bug Something isn't working good first issue Good for newcomers pr-opened A PR has been opened to resolve the issue

Comments

@pasimuno-ako
Copy link

pasimuno-ako commented May 16, 2024

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

In the Supabase website's Auth page, "Simple APIs" section, marketing text contents are being cut off based on screen size.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Go to Supabase Auth page.
  2. Scroll down to "Simple APIs" section
  3. See error on screen widths greater than 1024px.

Expected behavior

The marketing text should be fully visible.

Screenshots

Screenshot 2024-05-16 at 8 51 01 AM

System information

  • OS: N/A
  • Browser (if applies): Chrome (latest)
  • Version of supabase-js: N/A
  • Version of Node.js: N/A

Additional context

This line in the codebase:

<SectionContainer className="-mb-48">

Solution: Either remove the -mb-48 or add a new class sm:mb-0.

@pasimuno-ako pasimuno-ako added the bug Something isn't working label May 16, 2024
@Hallidayo
Copy link
Contributor

Hi @pasimuno-ako - Thank you for opening, feel free to open a PR for a fix.

@Hallidayo Hallidayo added the good first issue Good for newcomers label May 16, 2024
@H0onnn
Copy link
Contributor

H0onnn commented May 17, 2024

@Hallidayo @pasimuno-ako Hello ! Can I solve this issue ?

@Hallidayo
Copy link
Contributor

@H0onnn - of course! feel free to open a pull request.

@akar016012
Copy link
Contributor

akar016012 commented May 17, 2024

I have fixed the issue and opened a new pull request

image
image

#26495

@pasimuno-ako
Copy link
Author

pasimuno-ako commented May 17, 2024

@akar016012 Your solution works but is not ideal because adding the mt-20 simply negates the -mb-48 from the section above.

The ideal solution is to either remove the -mb-48 or add a new class to that element sm:mb-0 because it seems the negative margin is still being used on smaller screens (based on other pages' designs), but on desktop, the height of the text next to the code block are taller, so they get cut off.

@akar016012
Copy link
Contributor

Or simple fix would be to just correct this type -mb-48 to mb-48.

@pasimuno-ako
Copy link
Author

pasimuno-ako commented May 17, 2024

Or simple fix would be to just correct this type -mb-48 to mb-48.

No, because the negative margin is only used for small screens to achieve the effect of the code blocks being cut off by the next section's margin like this:

Screenshot 2024-05-17 at 12 46 53 PM

Which are also done on other pages without issues like in the Database page:

Screenshot 2024-05-17 at 12 49 01 PM

I updated my ideal solution recommendation in my previous comment above.

@akar016012
Copy link
Contributor

Yes, so I fixed the typos in two places and it makes the mobile view even better

Before:
image

After:
image

@pasimuno-ako
Copy link
Author

Actually, looking at the other pages beyond Database and Auth, it looks like the website is not consistent with when the code blocks get cut off by the section divider, so your solution may be adequate.

@Hallidayo Hallidayo added the pr-opened A PR has been opened to resolve the issue label May 18, 2024
@Muhammad-Owais-Warsi
Copy link

Can i work on this issue ??

@H0onnn
Copy link
Contributor

H0onnn commented May 23, 2024

@Muhammad-Owais-Warsi This issue has already opened PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers pr-opened A PR has been opened to resolve the issue
Projects
None yet
Development

No branches or pull requests

6 participants