Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Android add intents to toggle use exit node #8143

Closed
DarkFox opened this issue May 15, 2023 · 0 comments · Fixed by tailscale/tailscale-android#142
Closed

FR: Android add intents to toggle use exit node #8143

DarkFox opened this issue May 15, 2023 · 0 comments · Fixed by tailscale/tailscale-android#142
Labels
fr Feature request L2 Few Likelihood OS-android P1 Nuisance Priority level T0 New feature Issue type

Comments

@DarkFox
Copy link

DarkFox commented May 15, 2023

What are you trying to do?

In tailscale/tailscale-android#87 intents were added to connect or disconnect the VPN. It would be nice to also be able to toggle the use of an exit node, perhaps with the option to specify which exit node, using extra data.

How should we solve this?

No response

What is the impact of not solving this?

I'm currently turning on use exit node manually, when on untrusted networks.

Anything else?

No response
@DarkFox DarkFox added fr Feature request needs-triage labels May 15, 2023
@Mincka Mincka mentioned this issue May 22, 2023
Open
@DentonGentry DentonGentry changed the title FR: Add intents to toggle use exit node FR: Android add intents to toggle use exit node May 27, 2023
@DentonGentry DentonGentry added OS-android L2 Few Likelihood P1 Nuisance Priority level T0 New feature Issue type and removed needs-triage labels May 27, 2023
@333fred 333fred mentioned this issue Dec 9, 2023
Merged
barnstar pushed a commit to tailscale/tailscale-android that referenced this issue Jun 12, 2024
@333fred
android/ui: implement USE_EXIT_NODE intent (#142)
864cc35 
Fixes tailscale/tailscale#8143. 

Map friendly labels from intent extras to tailscale node IDs, with empty string or not specifying the exitNode intent extra as the "no exit node" action. When an error is encountered, we will push a notification with a friendly message to the status notification channel. The tasker syntax I tested with locally is:

Action: `com.tailscale.ipn.USE_EXIT_NODE`
Package: `com.tailscale.ipn`
Class: `com.tailscale.ipn.IPNReceiver`
Target: Broadcast Receiver
Extra: `exitNode:exitNodeLabelOrEmpty`
Extra: `allowLanAccess:trueOrFalse`

Signed-off-by: Fredric Silberberg <fred@silberberg.xyz>

* Extract constant strings to resources for later localization.

Signed-off-by: Fredric Silberberg <fred@silberberg.xyz>

---------

Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fr Feature request L2 Few Likelihood OS-android P1 Nuisance Priority level T0 New feature Issue type
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement USE_EXIT_NODE intent 333fred/tailscale-android
2 participants
@DarkFox @DentonGentry