Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facing issue when integrating Hanko with Remix, as remix does not convert commonjs modules to esmodules automatically #1159

Open
2 tasks done
Ashutosh-Bhadauriya opened this issue Nov 3, 2023 · 0 comments
Open
2 tasks done

Facing issue when integrating Hanko with Remix, as remix does not convert commonjs modules to esmodules automatically #1159

Ashutosh-Bhadauriya opened this issue Nov 3, 2023 · 0 comments
Labels
bug Something isn't working priority high

Comments

@Ashutosh-Bhadauriya
Copy link
Contributor

Ashutosh-Bhadauriya commented Nov 3, 2023 •
edited

Checklist

  • I could not find a solution in the existing issues or docs.
  • I agree to follow this project's Code of Conduct.

Describe the bug

Remix, unlike next.js or react app, doesn't transpile the node_modules folder, so it doesn't convert commonJS modules to ES modules. The reason for the error, ig. as the Hanko elements is a cjs module.

Would it possible to modify @teamhanko/hanko-elements to better support es modules without breaking anything or it would be even better if it can be converted to es-module.

Reproducing the bug

This repo helps with it, I have tried Hanko-Auth module with Remix in this, Hanko-Remix-Starter.

Screenshot_Oct_25_1
Screenshot_Oct_25

Hanko Version

0.9.0
@Ashutosh-Bhadauriya Ashutosh-Bhadauriya added the bug Something isn't working label Nov 3, 2023
@Ashutosh-Bhadauriya Ashutosh-Bhadauriya changed the title Facing issue when integrating Hanko with Remix, as remix does convert commonjs modules to esmodules automatically Facing issue when integrating Hanko with Remix, as remix does not convert commonjs modules to esmodules automatically Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority high
Projects
Hanko
Status: 🔖 Up next
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FlxMgdnz @Ashutosh-Bhadauriya