Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool/p2p: Research implications of peer disconnect based on ResponseCheckTx #9546

Closed
Tracked by #9428 ...
jmalicevic opened this issue Oct 13, 2022 · 0 comments · May be fixed by #9675
Closed
Tracked by #9428 ...

mempool/p2p: Research implications of peer disconnect based on ResponseCheckTx #9546

jmalicevic opened this issue Oct 13, 2022 · 0 comments · May be fixed by #9675
Assignees
Labels
stale for use by stalebot

Comments

@jmalicevic
Copy link
Contributor

jmalicevic commented Oct 13, 2022

As mentioned in #7918 and #2185, it might be of interest to disconnect from a peer when receiving transactions that could never have been valid.

Before implementing this behaviour we want to look into more details of such a behaviour. Namely:

  • The use case where a node sends transactions that could never have been valid;
  • Implications on the security and correctness model of Tendermint (how does the application know that it is this particular peer that should be removed, is this scenario not covered already by other layers in Tendermint, etc.);
  • What other changes in other parts of Tendermint should the implementation of this require;
  • If solution/problem still seem valuable, propose an implementation path taking into account potential need to refactor and change the p2p layer itself to support this.
@jmalicevic jmalicevic changed the title Research and document:- The use case for such behaviour;- Implications for the security and correctness model (how does the application know that it is this particular peer that should be removed, is this scenario not covered already by other layers in Tendermint, etc.);- What other changes in other parts of Tendermint should the implementation of this require;- If solution/problem still seem valuable, propose an implementation path taking into account potential need to refactor and change the p2p layer itself to support this. mempool/p2p: Research the removal of bad peers based on CheckTx return code Oct 13, 2022
@jmalicevic jmalicevic changed the title mempool/p2p: Research the removal of bad peers based on CheckTx return code mempool/p2p: Research implications of peer disconnect based on ResponseCheckTx Oct 13, 2022
@jmalicevic jmalicevic self-assigned this Oct 13, 2022
@jmalicevic jmalicevic added the priority A high-priority, high-level item to be shown on the priorities project board label Oct 13, 2022
@thanethomson thanethomson mentioned this issue Oct 17, 2022
19 tasks
@thanethomson thanethomson removed the priority A high-priority, high-level item to be shown on the priorities project board label Dec 22, 2022
@github-actions github-actions bot added the stale for use by stalebot label Feb 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale for use by stalebot
Projects
Status: Done/Merged
Development

Successfully merging a pull request may close this issue.

2 participants